* [PATCH] console/dummy: leave .con_font_get set to NULL @ 2018-01-05 21:42 ` Nicolas Pitre 2018-01-15 15:04 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 3+ messages in thread From: Nicolas Pitre @ 2018-01-05 21:42 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz; +Cc: dri-devel, linux-fbdev, linux-kernel When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space. Signed-off-by: Nicolas Pitre <nico@linaro.org> Cc: stable@kernel.org diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c index 9269d56852..b90ef96e43 100644 --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, }; ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] console/dummy: leave .con_font_get set to NULL 2018-01-05 21:42 ` [PATCH] console/dummy: leave .con_font_get set to NULL Nicolas Pitre @ 2018-01-15 15:04 ` Bartlomiej Zolnierkiewicz 2018-01-15 16:46 ` Nicolas Pitre 0 siblings, 1 reply; 3+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-01-15 15:04 UTC (permalink / raw) To: Nicolas Pitre; +Cc: linux-fbdev, linux-kernel, dri-devel On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote: > > When this method is set, the caller expects struct console_font fields > to be properly initialized when it returns. Leave it unset otherwise > nonsensical (leaked kernel stack) values are returned to user space. > > Signed-off-by: Nicolas Pitre <nico@linaro.org> > Cc: stable@kernel.org Please check your patches with tools/checkpatch.pl script: ERROR: The 'stable' address should be 'stable@vger.kernel.org' #9: Cc: stable@kernel.org After updating this I queued the patch for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] console/dummy: leave .con_font_get set to NULL 2018-01-15 15:04 ` Bartlomiej Zolnierkiewicz @ 2018-01-15 16:46 ` Nicolas Pitre 0 siblings, 0 replies; 3+ messages in thread From: Nicolas Pitre @ 2018-01-15 16:46 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz; +Cc: linux-fbdev, linux-kernel, dri-devel On Mon, 15 Jan 2018, Bartlomiej Zolnierkiewicz wrote: > On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote: > > > > When this method is set, the caller expects struct console_font fields > > to be properly initialized when it returns. Leave it unset otherwise > > nonsensical (leaked kernel stack) values are returned to user space. > > > > Signed-off-by: Nicolas Pitre <nico@linaro.org> > > Cc: stable@kernel.org > > Please check your patches with tools/checkpatch.pl script: > > ERROR: The 'stable' address should be 'stable@vger.kernel.org' > #9: > Cc: stable@kernel.org Oops. I cut and pasted it it from commit ea0ee33988778fb73e4f4. ;-) Nicolas ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-15 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180105214302epcas3p1881997414f06e7ff06141318a610ac5b@epcas3p1.samsung.com>
2018-01-05 21:42 ` [PATCH] console/dummy: leave .con_font_get set to NULL Nicolas Pitre
2018-01-15 15:04 ` Bartlomiej Zolnierkiewicz
2018-01-15 16:46 ` Nicolas Pitre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).