* [PATCH] fbdev: udlfb: Use usb_control_msg_send()
@ 2023-05-19 21:16 Helge Deller
2023-05-20 14:46 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Helge Deller @ 2023-05-19 21:16 UTC (permalink / raw)
To: linux-fbdev, dri-devel, stern
Use the newly introduced usb_control_msg_send() instead of usb_control_msg()
when selecting the channel.
Signed-off-by: Helge Deller <deller@gmx.de>
---
drivers/video/fbdev/udlfb.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 256d9b61f4ea..dabc30a09f96 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -1543,24 +1543,16 @@ static const struct device_attribute fb_device_attrs[] = {
static int dlfb_select_std_channel(struct dlfb_data *dlfb)
{
int ret;
- void *buf;
static const u8 set_def_chn[] = {
0x57, 0xCD, 0xDC, 0xA7,
0x1C, 0x88, 0x5E, 0x15,
0x60, 0xFE, 0xC6, 0x97,
0x16, 0x3D, 0x47, 0xF2 };
- buf = kmemdup(set_def_chn, sizeof(set_def_chn), GFP_KERNEL);
-
- if (!buf)
- return -ENOMEM;
-
- ret = usb_control_msg(dlfb->udev, usb_sndctrlpipe(dlfb->udev, 0),
- NR_USB_REQUEST_CHANNEL,
+ ret = usb_control_msg_send(dlfb->udev, 0, NR_USB_REQUEST_CHANNEL,
(USB_DIR_OUT | USB_TYPE_VENDOR), 0, 0,
- buf, sizeof(set_def_chn), USB_CTRL_SET_TIMEOUT);
-
- kfree(buf);
+ &set_def_chn, sizeof(set_def_chn), USB_CTRL_SET_TIMEOUT,
+ GFP_KERNEL);
return ret;
}
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: udlfb: Use usb_control_msg_send()
2023-05-19 21:16 [PATCH] fbdev: udlfb: Use usb_control_msg_send() Helge Deller
@ 2023-05-20 14:46 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2023-05-20 14:46 UTC (permalink / raw)
To: Helge Deller; +Cc: linux-fbdev, dri-devel
On Fri, May 19, 2023 at 11:16:25PM +0200, Helge Deller wrote:
> Use the newly introduced usb_control_msg_send() instead of usb_control_msg()
> when selecting the channel.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> drivers/video/fbdev/udlfb.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
> index 256d9b61f4ea..dabc30a09f96 100644
> --- a/drivers/video/fbdev/udlfb.c
> +++ b/drivers/video/fbdev/udlfb.c
> @@ -1543,24 +1543,16 @@ static const struct device_attribute fb_device_attrs[] = {
> static int dlfb_select_std_channel(struct dlfb_data *dlfb)
> {
> int ret;
> - void *buf;
> static const u8 set_def_chn[] = {
> 0x57, 0xCD, 0xDC, 0xA7,
> 0x1C, 0x88, 0x5E, 0x15,
> 0x60, 0xFE, 0xC6, 0x97,
> 0x16, 0x3D, 0x47, 0xF2 };
>
> - buf = kmemdup(set_def_chn, sizeof(set_def_chn), GFP_KERNEL);
> -
> - if (!buf)
> - return -ENOMEM;
> -
> - ret = usb_control_msg(dlfb->udev, usb_sndctrlpipe(dlfb->udev, 0),
> - NR_USB_REQUEST_CHANNEL,
> + ret = usb_control_msg_send(dlfb->udev, 0, NR_USB_REQUEST_CHANNEL,
> (USB_DIR_OUT | USB_TYPE_VENDOR), 0, 0,
> - buf, sizeof(set_def_chn), USB_CTRL_SET_TIMEOUT);
> -
> - kfree(buf);
> + &set_def_chn, sizeof(set_def_chn), USB_CTRL_SET_TIMEOUT,
> + GFP_KERNEL);
>
> return ret;
> }
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-20 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-19 21:16 [PATCH] fbdev: udlfb: Use usb_control_msg_send() Helge Deller
2023-05-20 14:46 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).