* [PATCH] fb_omap: add gpiolib dependency @ 2018-05-30 21:49 ` Arnd Bergmann 2018-05-31 6:04 ` Andy Shevchenko 2018-06-08 16:06 ` Bartlomiej Zolnierkiewicz 0 siblings, 2 replies; 4+ messages in thread From: Arnd Bergmann @ 2018-05-30 21:49 UTC (permalink / raw) To: Tomi Valkeinen, Bartlomiej Zolnierkiewicz Cc: Arnd Bergmann, linux-omap, linux-fbdev, dri-devel, linux-kernel Building the omap sub-drivers when CONFIG_GPIOLIB is disabled causes lots of build failures, either from using gpiolib interfaces, or from including the wrong headers: drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_enable': drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:101:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_enable': drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:86:2: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_pdata': drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:189:23: error: implicit declaration of function 'gpio_to_desc'; did you mean 'irq_to_desc'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_of': drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:210:9: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c: In function 'sharp_ls_enable': drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c:120:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c: In function 'lb035q02_enable': drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c:170:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] Rather than fixing up each one individually, this just marks all of it as depending on GPIOLIB. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/video/fbdev/omap2/omapfb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..3bf154e676d1 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -5,6 +5,7 @@ menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB depends on DRM_OMAP = n + depends on GPIOLIB select FB_OMAP2_DSS select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3 -- 2.9.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fb_omap: add gpiolib dependency 2018-05-30 21:49 ` [PATCH] fb_omap: add gpiolib dependency Arnd Bergmann @ 2018-05-31 6:04 ` Andy Shevchenko 2018-06-01 15:10 ` Arnd Bergmann 2018-06-08 16:06 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 4+ messages in thread From: Andy Shevchenko @ 2018-05-31 6:04 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Linux Kernel Mailing List, dri-devel, Tomi Valkeinen, Linux OMAP Mailing List On Thu, May 31, 2018 at 12:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] > Rather than fixing up each one individually, this just marks all of it > as depending on GPIOLIB. Hmm... But the OF stuff is not part of GPIOLIB. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fb_omap: add gpiolib dependency 2018-05-31 6:04 ` Andy Shevchenko @ 2018-06-01 15:10 ` Arnd Bergmann 0 siblings, 0 replies; 4+ messages in thread From: Arnd Bergmann @ 2018-06-01 15:10 UTC (permalink / raw) To: Andy Shevchenko Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Linux Kernel Mailing List, dri-devel, Tomi Valkeinen, Linux OMAP Mailing List On Thu, May 31, 2018 at 8:04 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, May 31, 2018 at 12:49 AM, Arnd Bergmann <arnd@arndb.de> wrote: > >> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': >> drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] >> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': >> drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] > >> Rather than fixing up each one individually, this just marks all of it >> as depending on GPIOLIB. > > Hmm... But the OF stuff is not part of GPIOLIB. The underlying issue is the same though: linux/gpio.h includes a different set of header files depending on CONFIG_GPIOLIB being set or not. Without it, we are missing all the indirect includes from asm-generic/gpio.h that include linux/of.h and linux/gpio/consumer.h. Arnd ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fb_omap: add gpiolib dependency 2018-05-30 21:49 ` [PATCH] fb_omap: add gpiolib dependency Arnd Bergmann 2018-05-31 6:04 ` Andy Shevchenko @ 2018-06-08 16:06 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-06-08 16:06 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-omap, Tomi Valkeinen, linux-fbdev, dri-devel, linux-kernel On Wednesday, May 30, 2018 11:49:22 PM Arnd Bergmann wrote: > Building the omap sub-drivers when CONFIG_GPIOLIB is disabled causes > lots of build failures, either from using gpiolib interfaces, or from > including the wrong headers: > > drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_enable': > drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:101:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_enable': > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:86:2: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_pdata': > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:189:23: error: implicit declaration of function 'gpio_to_desc'; did you mean 'irq_to_desc'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_of': > drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:210:9: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c: In function 'sharp_ls_enable': > drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c:120:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c: In function 'lb035q02_enable': > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c:170:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c: In function 'hdmi_probe_of': > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:584:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c: In function 'hdmi_probe_of': > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:554:2: error: implicit declaration of function 'of_node_put'; did you mean 'node_set'? [-Werror=implicit-function-declaration] > > Rather than fixing up each one individually, this just marks all of it > as depending on GPIOLIB. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch queued for 4.18 (w/ fb_omap->fb_omap2 fixed in the patch title), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-08 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20180530214948epcas1p43ed1ac72bc8959b7bf0f21220c48e96d@epcas1p4.samsung.com>
2018-05-30 21:49 ` [PATCH] fb_omap: add gpiolib dependency Arnd Bergmann
2018-05-31 6:04 ` Andy Shevchenko
2018-06-01 15:10 ` Arnd Bergmann
2018-06-08 16:06 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).