* [PATCH 0/2] video/fbdev/mmp: Adjustments for two function implementations @ 2017-11-26 20:41 SF Markus Elfring 2017-11-26 20:42 ` [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two function SF Markus Elfring 2017-11-26 20:43 ` [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init() SF Markus Elfring 0 siblings, 2 replies; 5+ messages in thread From: SF Markus Elfring @ 2017-11-26 20:41 UTC (permalink / raw) To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz; +Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 26 Nov 2017 21:38:42 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Improve a size determination in path_init() drivers/video/fbdev/mmp/fb/mmpfb.c | 5 ++--- drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 8 +++----- 2 files changed, 5 insertions(+), 8 deletions(-) -- 2.15.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two function 2017-11-26 20:41 [PATCH 0/2] video/fbdev/mmp: Adjustments for two function implementations SF Markus Elfring @ 2017-11-26 20:42 ` SF Markus Elfring 2018-04-26 10:08 ` [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two func Bartlomiej Zolnierkiewicz 2017-11-26 20:43 ` [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init() SF Markus Elfring 1 sibling, 1 reply; 5+ messages in thread From: SF Markus Elfring @ 2017-11-26 20:42 UTC (permalink / raw) To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz; +Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 26 Nov 2017 21:16:30 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/video/fbdev/mmp/fb/mmpfb.c | 5 ++--- drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 6 ++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/mmp/fb/mmpfb.c b/drivers/video/fbdev/mmp/fb/mmpfb.c index 92279e02dd94..292b3e403044 100644 --- a/drivers/video/fbdev/mmp/fb/mmpfb.c +++ b/drivers/video/fbdev/mmp/fb/mmpfb.c @@ -495,10 +495,9 @@ static int modes_setup(struct mmpfb_info *fbi) /* put videomode list to info structure */ videomodes = kzalloc(sizeof(struct fb_videomode) * videomode_num, GFP_KERNEL); - if (!videomodes) { - dev_err(fbi->dev, "can't malloc video modes\n"); + if (!videomodes) return -ENOMEM; - } + for (i = 0; i < videomode_num; i++) mmpmode_to_fbmode(&videomodes[i], &mmp_modes[i]); fb_videomode_to_modelist(videomodes, videomode_num, &info->modelist); diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c index b6f83d5df9fd..9f912ea0bfce 100644 --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c @@ -407,11 +407,9 @@ static int path_init(struct mmphw_path_plat *path_plat, /* init driver data */ path_info = kzalloc(sizeof(struct mmp_path_info), GFP_KERNEL); - if (!path_info) { - dev_err(ctrl->dev, "%s: unable to alloc path_info for %s\n", - __func__, config->name); + if (!path_info) return 0; - } + path_info->name = config->name; path_info->id = path_plat->id; path_info->dev = ctrl->dev; -- 2.15.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two func 2017-11-26 20:42 ` [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two function SF Markus Elfring @ 2018-04-26 10:08 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-04-26 10:08 UTC (permalink / raw) To: SF Markus Elfring; +Cc: linux-fbdev, kernel-janitors, LKML, dri-devel On Sunday, November 26, 2017 09:42:49 PM SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 26 Nov 2017 21:16:30 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init() 2017-11-26 20:41 [PATCH 0/2] video/fbdev/mmp: Adjustments for two function implementations SF Markus Elfring 2017-11-26 20:42 ` [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two function SF Markus Elfring @ 2017-11-26 20:43 ` SF Markus Elfring 2018-04-26 10:10 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 5+ messages in thread From: SF Markus Elfring @ 2017-11-26 20:43 UTC (permalink / raw) To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz; +Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 26 Nov 2017 21:21:33 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c index 9f912ea0bfce..fcdbb2df137f 100644 --- a/drivers/video/fbdev/mmp/hw/mmp_ctrl.c +++ b/drivers/video/fbdev/mmp/hw/mmp_ctrl.c @@ -406,7 +406,7 @@ static int path_init(struct mmphw_path_plat *path_plat, dev_info(ctrl->dev, "%s: %s\n", __func__, config->name); /* init driver data */ - path_info = kzalloc(sizeof(struct mmp_path_info), GFP_KERNEL); + path_info = kzalloc(sizeof(*path_info), GFP_KERNEL); if (!path_info) return 0; -- 2.15.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init() 2017-11-26 20:43 ` [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init() SF Markus Elfring @ 2018-04-26 10:10 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-04-26 10:10 UTC (permalink / raw) To: SF Markus Elfring; +Cc: linux-fbdev, kernel-janitors, LKML, dri-devel On Sunday, November 26, 2017 09:43:52 PM SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 26 Nov 2017 21:21:33 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-26 10:10 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-26 20:41 [PATCH 0/2] video/fbdev/mmp: Adjustments for two function implementations SF Markus Elfring 2017-11-26 20:42 ` [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two function SF Markus Elfring 2018-04-26 10:08 ` [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two func Bartlomiej Zolnierkiewicz 2017-11-26 20:43 ` [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init() SF Markus Elfring 2018-04-26 10:10 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).