From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Karel Balej <balejk@matfyz.cz>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/2] backlight: Add Kinetic KTD2801 driver
Date: Fri, 06 Oct 2023 15:11:58 +0200 [thread overview]
Message-ID: <2306278.ElGaqSPkdT@radijator> (raw)
In-Reply-To: <d7f6edd4-d797-4a6f-8df5-d25bc557c9bb@kernel.org>
On Thursday, October 5, 2023 10:40:41 PM CEST Krzysztof Kozlowski wrote:
> On 05/10/2023 20:49, Duje Mihanović wrote:
> > + gpiod_set_value(ktd2801->desc, 0);
> > + udelay(EOD_H);
>
> Hm, why device is kept off after this? Setting 0 means enable GPIO is
> logical 0.
...
> > + ktd2801->desc = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
>
> OUT_LOW is keep it disabled, so is this intentional?
I initially wrote the driver to expect GPIO_ACTIVE_LOW, a decision which in
retrospect indeed makes no sense. If you have no objections, I'll change it to
expect GPIO_ACTIVE_HIGH.
Regards,
Duje
next prev parent reply other threads:[~2023-10-06 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 18:49 [PATCH 0/2] Kinetic KTD2801 backlight driver Duje Mihanović
2023-10-05 18:49 ` [PATCH 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding Duje Mihanović
2023-10-05 20:37 ` Krzysztof Kozlowski
2023-10-06 12:30 ` Daniel Thompson
2023-10-06 13:08 ` Duje Mihanović
2023-10-09 9:29 ` Daniel Thompson
2023-10-05 18:49 ` [PATCH 2/2] backlight: Add Kinetic KTD2801 driver Duje Mihanović
2023-10-05 20:40 ` Krzysztof Kozlowski
2023-10-06 13:11 ` Duje Mihanović [this message]
2023-10-09 9:21 ` Daniel Thompson
2023-10-09 15:08 ` Duje Mihanović
2023-10-10 17:20 ` kernel test robot
2023-10-19 1:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2306278.ElGaqSPkdT@radijator \
--to=duje.mihanovic@skole.hr \
--cc=balejk@matfyz.cz \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).