From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: omapdrm: remove unused variable
Date: Sat, 10 Jun 2017 09:04:40 +0000 [thread overview]
Message-ID: <2360322.E0GRGgjHx9@avalon> (raw)
In-Reply-To: <20170609103143.3095325-1-arnd@arndb.de>
Hi Arnd,
Thank you for the patch.
On Friday 09 Jun 2017 12:31:03 Arnd Bergmann wrote:
> Removing the default display name left a harmless warning:
>
> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata'
> [-Werror=unused-variable]
>
> This removes the now-unused variable as well.
>
> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name
> support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c
> b/drivers/video/fbdev/omap2/omapfb/dss/core.c index
> eecf695c16f4..09e5bb013d28 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
> @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
>
> static int __init omap_dss_probe(struct platform_device *pdev)
> {
> - struct omap_dss_board_info *pdata = pdev->dev.platform_data;
> int r;
>
> core.pdev = pdev;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2017-06-10 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:31 [PATCH] drm: omapdrm: remove unused variable Arnd Bergmann
2017-06-10 9:04 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2360322.E0GRGgjHx9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox