From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 01 Aug 2017 13:53:28 +0000 Subject: Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures. Message-Id: <2391550.2naV14eqVs@amdc3058> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arvind Yadav Cc: spock@gentoo.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o > > File size After adding 'const': > text data bss dec hex filename > 15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o > > Signed-off-by: Arvind Yadav Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics