From: Hans de Goede <hdegoede@redhat.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, linux-clk@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h>
Date: Tue, 19 Jun 2018 17:30:50 +0000 [thread overview]
Message-ID: <23991cf4-d926-246d-2362-a28d490eb246@redhat.com> (raw)
In-Reply-To: <20180619172221.20252-1-geert+renesas@glider.be>
Hi,
On 19-06-18 19:22, Geert Uytterhoeven wrote:
> Simplefb is not a clock provider, but it uses of_clk_get_parent_count(),
> so it can just include <linux/of_clk.h> instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
LGTM:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/video/fbdev/simplefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index a3c44ecf4523e8ed..9a9d748b07f2777d 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -27,8 +27,8 @@
> #include <linux/platform_data/simplefb.h>
> #include <linux/platform_device.h>
> #include <linux/clk.h>
> -#include <linux/clk-provider.h>
> #include <linux/of.h>
> +#include <linux/of_clk.h>
> #include <linux/of_platform.h>
> #include <linux/parser.h>
> #include <linux/regulator/consumer.h>
>
next prev parent reply other threads:[~2018-06-19 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180619172229epcas3p15ff0f115330cd4ffea687479cc929738@epcas3p1.samsung.com>
2018-06-19 17:22 ` [PATCH] video: fbdev: simplefb: Stop including <linux/clk-provider.h> Geert Uytterhoeven
2018-06-19 17:30 ` Hans de Goede [this message]
2018-06-19 20:12 ` Stephen Boyd
2018-07-03 15:10 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23991cf4-d926-246d-2362-a28d490eb246@redhat.com \
--to=hdegoede@redhat.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox