From: Thomas Huth <thuth@redhat.com>
To: Farhan Ali <alifm@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fbdev@vger.kernel.org
Cc: geert@linux-m68k.org, borntraeger@de.ibm.com,
tomi.valkeinen@ti.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables
Date: Mon, 19 Feb 2018 19:52:22 +0000 [thread overview]
Message-ID: <250077c8-ccef-fbbc-1d53-8a5cc3984243@redhat.com> (raw)
In-Reply-To: <4e0d31cf01c9fff5fe177338f14b1ca3f6871fb5.1519053920.git.alifm@linux.vnet.ibm.com>
On 19.02.2018 16:47, Farhan Ali wrote:
> The Linux Virtual Terminal (VT) layer provides a default keymap
> which is compiled when VT layer is enabled. But at the same time
> we are also compiling the EBCDIC keymap and this causes the linker
> to complain.
>
> So let's rename the EBCDIC keymap variables to prevent linker
> conflict.
>
> Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> drivers/s390/char/defkeymap.c | 66 ++++++++++++++++++++++---------------------
> drivers/s390/char/keyboard.c | 32 ++++++++++-----------
> drivers/s390/char/keyboard.h | 11 ++++++++
> 3 files changed, 61 insertions(+), 48 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-02-19 19:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 15:47 [PATCH v3 0/3] Enable CONFIG_VT support for S390 Farhan Ali
2018-02-19 15:47 ` [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support Farhan Ali
2018-02-19 16:25 ` Thomas Huth
2018-02-19 16:38 ` Farhan Ali
2018-02-21 10:05 ` Christian Borntraeger
2018-02-21 10:22 ` Christian Borntraeger
2018-02-21 10:32 ` Cornelia Huck
2018-02-21 11:09 ` Christian Borntraeger
2018-02-21 11:14 ` Thomas Huth
2018-02-21 11:22 ` Christian Borntraeger
2018-02-21 11:29 ` Thomas Huth
2018-02-21 11:49 ` Christian Borntraeger
2018-02-21 12:07 ` Cornelia Huck
2018-02-21 12:11 ` Christian Borntraeger
2018-02-21 16:39 ` Farhan Ali
2018-02-22 7:34 ` Christian Borntraeger
2018-02-21 11:23 ` Cornelia Huck
2018-02-21 8:44 ` Christian Borntraeger
2018-02-21 11:50 ` Bartlomiej Zolnierkiewicz
2018-02-19 15:47 ` [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables Farhan Ali
2018-02-19 19:52 ` Thomas Huth [this message]
2018-02-19 15:47 ` [PATCH v3 3/3] s390/setup : enable display support for KVM guest Farhan Ali
2018-02-19 19:55 ` Thomas Huth
2018-02-20 9:43 ` [PATCH v3 0/3] Enable CONFIG_VT support for S390 Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=250077c8-ccef-fbbc-1d53-8a5cc3984243@redhat.com \
--to=thuth@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=b.zolnierkie@samsung.com \
--cc=borntraeger@de.ibm.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).