From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Mon, 23 Apr 2018 12:47:28 +0000 Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-Id: <2542100.cElVns0SR0@amdc3058> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > Add stubs for omapfb_dss.h, in the case it is included by > some driver when CONFIG_FB_OMAP2 is not defined, with can > happen on ARM when DRM_OMAP is not 'n'. > > That allows building such driver(s) with COMPILE_TEST. > > Signed-off-by: Mauro Carvalho Chehab This patch should be dropped (together with patch #6/7) as it was superseded by a better solution suggested by Laurent: https://patchwork.kernel.org/patch/10325193/ ACK-ed by Tomi: https://www.spinics.net/lists/dri-devel/msg171918.html and already merged by you (commit 7378f1149884 "media: omap2: omapfb: allow building it with COMPILE_TEST").. > --- > include/video/omapfb_dss.h | 54 ++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 52 insertions(+), 2 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics