Re: [External] : Re: [bug report] staging: sm750fb: Fix polarity assignment for vertical and horizontal mode

[ALOK TIWARI <alok.a.tiwari@oracle.com>]

On 7/31/2025 9:41 PM, Dan Carpenter wrote:
> On Wed, Jul 23, 2025 at 12:24:31PM -0700, Alok Tiwari wrote:
>> In drivers/staging/sm750fb/sm750_hw.c,
>> the vertical and horizontal sync polarity assignments were incorrectly
>> ordered.
>> The assignment for modparm.vertical_sync_polarity was mistakenly using
>> the FB_SYNC_HOR_HIGH_ACT bit instead of FB_SYNC_VERT_HIGH_ACT,
>> and the horizontal polarity line was commented out or missing.
>>
>> This patch corrects the logic by properly assigning:
>>
>> vertical_sync_polarity -> from FB_SYNC_VERT_HIGH_ACT
>> horizontal_sync_polarity -> from FB_SYNC_HOR_HIGH_ACT
>>
>> Please let me know your feedback.
>> Thanks,
>> Alok
>> ---
>> Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
>> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>> ---
> 
> Did you find this copy and paste bug by testing or reviewing the code?
> How does this bug look like to a user?  Please put that in your commit
> message.
> 
> This looks reasonable to me, but the patch is badly formatted.
> 
> 1) It should say [PATCH] in the subject.
> 2) The body of the email should be the commit message.
> 3) the --- should only come after the Signed-off-by line.
> 
> Try applying your patch with `git am` and review the log to see what I
> mean.
> 
> regards,
> dan carpenter
> 


Thanks Dan. By reviewing the code, I noticed some awkward assignment.
However, I was not sure about this code, so instead of sending a formal 
patch, I just removed my SB and marked it as a [bug report].
I will send formal patch with proper SB.


Thanks,
Alok