From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: via: remove possibly unused variables
Date: Wed, 14 Jun 2017 10:19:38 +0000 [thread overview]
Message-ID: <2570388.yn7rRtV55D@amdc3058> (raw)
In-Reply-To: <20170516112906.4144714-1-arnd@arndb.de>
On Tuesday, May 16, 2017 01:28:57 PM Arnd Bergmann wrote:
> When CONFIG_PROC_FS is disabled, we get warnings about unused variables
> as remove_proc_entry() evaluates to an empty macro.
>
> drivers/video/fbdev/via/viafbdev.c: In function 'viafb_remove_proc':
> drivers/video/fbdev/via/viafbdev.c:1635:4: error: unused variable 'iga2_entry' [-Werror=unused-variable]
> drivers/video/fbdev/via/viafbdev.c:1634:4: error: unused variable 'iga1_entry' [-Werror=unused-variable]
>
> These are easy to avoid by using the pointer from the structure.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch queued for 4.12, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-06-14 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170516112912epcas1p39fe29bd07d9f8ac978b3908992dc7cbf@epcas1p3.samsung.com>
2017-05-16 11:28 ` [PATCH] fbdev: via: remove possibly unused variables Arnd Bergmann
2017-06-14 10:19 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2570388.yn7rRtV55D@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=arnd@arndb.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox