* [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step
@ 2012-07-26 12:36 Laurent Pinchart
2012-07-30 1:25 ` Kuninori Morimoto
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Laurent Pinchart @ 2012-07-26 12:36 UTC (permalink / raw)
To: linux-fbdev
Commit 15dede882e564601947f2ce4b647742c0351be6d added support for
horizontal panning but accidentally computes the Y pan step value
incorrectly for NV12/21 and NV16/61 formats. Fix this.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/video/sh_mobile_lcdcfb.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
index 8cb653b..699487c 100644
--- a/drivers/video/sh_mobile_lcdcfb.c
+++ b/drivers/video/sh_mobile_lcdcfb.c
@@ -1716,11 +1716,11 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl)
info->fix.visual = FB_VISUAL_TRUECOLOR;
switch (ovl->format->fourcc) {
- case V4L2_PIX_FMT_NV16:
- case V4L2_PIX_FMT_NV61:
- info->fix.ypanstep = 2;
case V4L2_PIX_FMT_NV12:
case V4L2_PIX_FMT_NV21:
+ info->fix.ypanstep = 2;
+ case V4L2_PIX_FMT_NV16:
+ case V4L2_PIX_FMT_NV61:
info->fix.xpanstep = 2;
}
@@ -2215,11 +2215,11 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch,
info->fix.visual = FB_VISUAL_TRUECOLOR;
switch (ch->format->fourcc) {
- case V4L2_PIX_FMT_NV16:
- case V4L2_PIX_FMT_NV61:
- info->fix.ypanstep = 2;
case V4L2_PIX_FMT_NV12:
case V4L2_PIX_FMT_NV21:
+ info->fix.ypanstep = 2;
+ case V4L2_PIX_FMT_NV16:
+ case V4L2_PIX_FMT_NV61:
info->fix.xpanstep = 2;
}
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step
2012-07-26 12:36 [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step Laurent Pinchart
@ 2012-07-30 1:25 ` Kuninori Morimoto
2012-08-06 15:26 ` Laurent Pinchart
2012-08-07 1:27 ` Kuninori Morimoto
2 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2012-07-30 1:25 UTC (permalink / raw)
To: linux-fbdev
Hi Laurent
> diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
> index 8cb653b..699487c 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -1716,11 +1716,11 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl)
> info->fix.visual = FB_VISUAL_TRUECOLOR;
>
> switch (ovl->format->fourcc) {
> - case V4L2_PIX_FMT_NV16:
> - case V4L2_PIX_FMT_NV61:
> - info->fix.ypanstep = 2;
> case V4L2_PIX_FMT_NV12:
> case V4L2_PIX_FMT_NV21:
> + info->fix.ypanstep = 2;
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> info->fix.xpanstep = 2;
> }
>
> @@ -2215,11 +2215,11 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch,
> info->fix.visual = FB_VISUAL_TRUECOLOR;
>
> switch (ch->format->fourcc) {
> - case V4L2_PIX_FMT_NV16:
> - case V4L2_PIX_FMT_NV61:
> - info->fix.ypanstep = 2;
> case V4L2_PIX_FMT_NV12:
> case V4L2_PIX_FMT_NV21:
> + info->fix.ypanstep = 2;
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> info->fix.xpanstep = 2;
> }
If possible, could you please add comment /* fall through */ ?
current code is a little bit confusing
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step
2012-07-26 12:36 [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step Laurent Pinchart
2012-07-30 1:25 ` Kuninori Morimoto
@ 2012-08-06 15:26 ` Laurent Pinchart
2012-08-07 1:27 ` Kuninori Morimoto
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2012-08-06 15:26 UTC (permalink / raw)
To: linux-fbdev
Hi Morimoto-san,
On Sunday 29 July 2012 18:25:59 Kuninori Morimoto wrote:
> > diff --git a/drivers/video/sh_mobile_lcdcfb.c
> > b/drivers/video/sh_mobile_lcdcfb.c index 8cb653b..699487c 100644
> > --- a/drivers/video/sh_mobile_lcdcfb.c
> > +++ b/drivers/video/sh_mobile_lcdcfb.c
> > @@ -1716,11 +1716,11 @@ sh_mobile_lcdc_overlay_fb_init(struct
> > sh_mobile_lcdc_overlay *ovl)>
> > info->fix.visual = FB_VISUAL_TRUECOLOR;
> >
> > switch (ovl->format->fourcc) {
> >
> > - case V4L2_PIX_FMT_NV16:
> > - case V4L2_PIX_FMT_NV61:
> > - info->fix.ypanstep = 2;
> > case V4L2_PIX_FMT_NV12:
> > case V4L2_PIX_FMT_NV21:
> > + info->fix.ypanstep = 2;
> > + case V4L2_PIX_FMT_NV16:
> > + case V4L2_PIX_FMT_NV61:
> > info->fix.xpanstep = 2;
> > }
> >
> > @@ -2215,11 +2215,11 @@ sh_mobile_lcdc_channel_fb_init(struct
> > sh_mobile_lcdc_chan *ch,
> > info->fix.visual = FB_VISUAL_TRUECOLOR;
> >
> > switch (ch->format->fourcc) {
> > - case V4L2_PIX_FMT_NV16:
> > - case V4L2_PIX_FMT_NV61:
> > - info->fix.ypanstep = 2;
> > case V4L2_PIX_FMT_NV12:
> > case V4L2_PIX_FMT_NV21:
> > + info->fix.ypanstep = 2;
> > + case V4L2_PIX_FMT_NV16:
> > + case V4L2_PIX_FMT_NV61:
> > info->fix.xpanstep = 2;
> > }
>
> If possible, could you please add comment /* fall through */ ?
> current code is a little bit confusing
I'm afraid the code has already been pushed to v3.6-rc1 :-S
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step
2012-07-26 12:36 [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step Laurent Pinchart
2012-07-30 1:25 ` Kuninori Morimoto
2012-08-06 15:26 ` Laurent Pinchart
@ 2012-08-07 1:27 ` Kuninori Morimoto
2 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2012-08-07 1:27 UTC (permalink / raw)
To: linux-fbdev
Dear Laurent
> > If possible, could you please add comment /* fall through */ ?
> > current code is a little bit confusing
>
> I'm afraid the code has already been pushed to v3.6-rc1 :-S
OK. no worry :)
Best regards
--
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-07 1:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-26 12:36 [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step Laurent Pinchart
2012-07-30 1:25 ` Kuninori Morimoto
2012-08-06 15:26 ` Laurent Pinchart
2012-08-07 1:27 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).