linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org
Cc: Michal Simek <monstr@monstr.eu>,
	Michal Simek <michal.simek@xilinx.com>,
	Arnd Bergmann <arnd@arndb.de>, Timur Tabi <timur@tabi.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: [PATCH v4 1/7] video: xilinxfb: Fix OF probing on little-endian systems
Date: Mon, 03 Jun 2013 10:13:16 +0000	[thread overview]
Message-ID: <262ff72a86eda8d0dfadd11783340a77d04e9b67.1370254386.git.michal.simek@xilinx.com> (raw)
In-Reply-To: <cover.1370254386.git.michal.simek@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

From: Michal Simek <monstr@monstr.eu>

DTB is always big-endian that's why it is necessary
to properly convert value (*p).
It is automatically done in of_property_read_u32().

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v4: None
Changes in v3:
- fix commit message

Changes in v2:
- use of_property_read_u32 helper function

 drivers/video/xilinxfb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
index af0b4fd..aecd15d 100644
--- a/drivers/video/xilinxfb.c
+++ b/drivers/video/xilinxfb.c
@@ -406,8 +406,7 @@ static int xilinxfb_release(struct device *dev)
 static int xilinxfb_of_probe(struct platform_device *op)
 {
 	const u32 *prop;
-	u32 *p;
-	u32 tft_access;
+	u32 tft_access = 0;
 	struct xilinxfb_platform_data pdata;
 	struct resource res;
 	int size, rc;
@@ -427,8 +426,8 @@ static int xilinxfb_of_probe(struct platform_device *op)
 	 * To check whether the core is connected directly to DCR or PLB
 	 * interface and initialize the tft_access accordingly.
 	 */
-	p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL);
-	tft_access = p ? *p : 0;
+	of_property_read_u32(op->dev.of_node, "xlnx,dcr-splb-slave-if",
+			     &tft_access);

 	/*
 	 * Fill the resource structure if its direct PLB interface
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2013-06-03 10:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 10:13 [PATCH v4 0/7] xilinxfb changes Michal Simek
2013-06-03 10:13 ` Michal Simek [this message]
2013-06-03 10:13 ` [PATCH v4 2/7] video: xilinxfb: Do not name out_be32 in function name Michal Simek
2013-06-03 10:13 ` [PATCH v4 3/7] video: xilinxfb: Rename PLB_ACCESS_FLAG to BUS_ACCESS_FLAG Michal Simek
2013-06-03 10:13 ` [PATCH v4 4/7] video: xilinxfb: Use drvdata->regs_phys instead of physaddr Michal Simek
2013-06-03 10:13 ` [PATCH v4 5/7] video: xilinxfb: Group bus initialization Michal Simek
2013-06-03 10:13 ` [PATCH v4 6/7] video: xilinxfb: Add support for little endian accesses Michal Simek
2013-06-03 10:13 ` [PATCH v4 7/7] video: xilinxfb: Use driver for Xilinx ARM Zynq Michal Simek
     [not found] ` <cover.1370254386.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2013-06-06 16:23   ` [PATCH v4 0/7] xilinxfb changes Jean-Christophe PLAGNIOL-VILLARD
2013-06-17  5:23     ` Michal Simek
2013-06-17  8:56       ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-17  9:02         ` Michal Simek
     [not found]           ` <51BED093.1040207-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2013-06-17 21:07             ` Arnd Bergmann
2013-06-26 10:02               ` Michal Simek
2013-06-26 11:41                 ` Tomi Valkeinen
2013-06-26 12:51                   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=262ff72a86eda8d0dfadd11783340a77d04e9b67.1370254386.git.michal.simek@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=arnd@arndb.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=plagnioj@jcrosoft.com \
    --cc=rob.herring@calxeda.com \
    --cc=timur@tabi.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).