linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC 7/9] omapfb: move vrfb into omapfb
Date: Sun, 13 Dec 2015 19:13:21 +0000	[thread overview]
Message-ID: <26366528.DG0zY3a8a2@avalon> (raw)
In-Reply-To: <1449757535-5674-8-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thank you for the patch.

On Thursday 10 December 2015 16:25:33 Tomi Valkeinen wrote:
> VRFB is only used by omapfb, so we can move it under omapfb's directory.

Do you see any specific blocker for support of vrfb in omapdss, apart from 
finding time (and a reason) to implement it ?

> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  drivers/video/fbdev/omap2/Kconfig             | 3 ---
>  drivers/video/fbdev/omap2/Makefile            | 2 --
>  drivers/video/fbdev/omap2/omapfb/Kconfig      | 3 +++
>  drivers/video/fbdev/omap2/omapfb/Makefile     | 1 +
>  drivers/video/fbdev/omap2/{ => omapfb}/vrfb.c | 0
>  5 files changed, 4 insertions(+), 5 deletions(-)
>  rename drivers/video/fbdev/omap2/{ => omapfb}/vrfb.c (100%)
> 
> diff --git a/drivers/video/fbdev/omap2/Kconfig
> b/drivers/video/fbdev/omap2/Kconfig index c22955d2de9a..7fbdb583de8c 100644
> --- a/drivers/video/fbdev/omap2/Kconfig
> +++ b/drivers/video/fbdev/omap2/Kconfig
> @@ -1,6 +1,3 @@
> -config OMAP2_VRFB
> -	bool
> -
>  if ARCH_OMAP2PLUS
> 
>  source "drivers/video/fbdev/omap2/dss/Kconfig"
> diff --git a/drivers/video/fbdev/omap2/Makefile
> b/drivers/video/fbdev/omap2/Makefile index c73a1e864ae8..a52b716a40c1
> 100644
> --- a/drivers/video/fbdev/omap2/Makefile
> +++ b/drivers/video/fbdev/omap2/Makefile
> @@ -1,5 +1,3 @@
> -obj-$(CONFIG_OMAP2_VRFB) += vrfb.o
> -
>  obj-y += dss/
>  obj-y += displays-new/
>  obj-y += omapfb/
> diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig
> b/drivers/video/fbdev/omap2/omapfb/Kconfig index 13d99a9e6198..e6226aeed17e
> 100644
> --- a/drivers/video/fbdev/omap2/omapfb/Kconfig
> +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig
> @@ -1,3 +1,6 @@
> +config OMAP2_VRFB
> +	bool
> +
>  menuconfig FB_OMAP2
>          tristate "OMAP2+ frame buffer support"
>          depends on FB
> diff --git a/drivers/video/fbdev/omap2/omapfb/Makefile
> b/drivers/video/fbdev/omap2/omapfb/Makefile index
> 0490951f95b3..ad68ecf141af 100644
> --- a/drivers/video/fbdev/omap2/omapfb/Makefile
> +++ b/drivers/video/fbdev/omap2/omapfb/Makefile
> @@ -1,3 +1,4 @@
> +obj-$(CONFIG_OMAP2_VRFB) += vrfb.o
>  obj-y += dss/
>  obj-y += displays/
>  obj-$(CONFIG_FB_OMAP2) += omapfb.o
> diff --git a/drivers/video/fbdev/omap2/vrfb.c
> b/drivers/video/fbdev/omap2/omapfb/vrfb.c similarity index 100%
> rename from drivers/video/fbdev/omap2/vrfb.c
> rename to drivers/video/fbdev/omap2/omapfb/vrfb.c

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-12-13 19:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 14:25 [PATCH RFC 0/9] omapdrm/omapfb/omapdss split Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 1/9] omapfb: allow compilation only if DRM_OMAP is disabled Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 3/9] omapdss: remove CONFIG_OMAP2_DSS_VENC from omapdss.h Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 4/9] omapfb/dss: change CONFIG_OMAP* to CONFIG_FB_OMAP* Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 5/9] omapfb/displays: change CONFIG_DISPLAY_* to CONFIG_FB_OMAP2_* Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 6/9] omapfb: take omapfb's prive omapdss into use Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 7/9] omapfb: move vrfb into omapfb Tomi Valkeinen
2015-12-13 19:13   ` Laurent Pinchart [this message]
2015-12-14  7:14     ` Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 8/9] drm/omap: move omapdss & displays under omapdrm Tomi Valkeinen
2015-12-13 19:08   ` Laurent Pinchart
2015-12-14  7:12     ` Tomi Valkeinen
2015-12-10 14:25 ` [PATCH RFC 9/9] drm/omap: make omapdrm select OMAP2_DSS Tomi Valkeinen
2015-12-10 14:53 ` [PATCH RFC 0/9] omapdrm/omapfb/omapdss split Rob Clark
2015-12-10 14:58   ` Tomi Valkeinen
2015-12-10 17:00   ` Emil Velikov
2015-12-10 17:15     ` Tomi Valkeinen
2015-12-11  6:26 ` Archit Taneja
2015-12-11  7:57   ` Tomi Valkeinen
2015-12-11 11:44     ` Archit Taneja
2015-12-16 15:52 ` Tomi Valkeinen
2015-12-16 22:11   ` Rob Clark
2015-12-17  0:22     ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26366528.DG0zY3a8a2@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).