Re: [PATCH -next] video: fbdev: goldfishfb: Do not check 0 for platform_get_irq()

[Helge Deller <deller@gmx.de>]

On 8/3/23 09:10, Zhu Wang wrote:
> Since platform_get_irq() never returned zero, so it need not to check
> whether it returned zero, and we use the return error code of
> platform_get_irq() to replace the current return error code.
>
> Please refer to the commit a85a6c86c25b ("driver core: platform: Clarify
> that IRQ 0 is invalid") to get that platform_get_irq() never returned
> zero.
>
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/goldfishfb.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c
> index ef2528c3faa9..c3091ce26e5c 100644
> --- a/drivers/video/fbdev/goldfishfb.c
> +++ b/drivers/video/fbdev/goldfishfb.c
> @@ -203,8 +203,8 @@ static int goldfish_fb_probe(struct platform_device *pdev)
>   	}
>
>   	fb->irq = platform_get_irq(pdev, 0);
> -	if (fb->irq <= 0) {
> -		ret = -ENODEV;
> +	if (fb->irq < 0) {
> +		ret = fb->irq;
>   		goto err_no_irq;
>   	}
>