From: br.shurik@gmail.com
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix lock context error
Date: Mon, 24 Oct 2016 12:12:40 +0000 [thread overview]
Message-ID: <2875616.l5QEf7t0yO@shurik> (raw)
In-Reply-To: <d825266ad9ed386b54656605fe1f805c576ebf42.1477226129.git.br.shurik@gmail.com>
On Monday, 24 October 2016 13:41:39 IDT Dan Carpenter wrote:
> evaluation
Hi Dan,
Thanks you for your feedback, it kind of felt like workaround.
However, it seems to me like bad design decision took place where locking/
unlocking is dependent on unprotected variable.
From what I could understand from the driver source code the fb_count value
shouldn't change while in those functions, so the code is safe "as is" and my
change should only assist with readability.
So the patch fails to improve readability it is unnecessary.
Best regards,
Alex
prev parent reply other threads:[~2016-10-24 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 12:37 [PATCH] staging: sm750fb: Fix lock context error Alex Briskin
2016-10-24 10:41 ` Dan Carpenter
2016-10-24 12:12 ` br.shurik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2875616.l5QEf7t0yO@shurik \
--to=br.shurik@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox