From: Helge Deller <deller@gmx.de>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: goldfishfb: fail pan display on base-update timeout
Date: Thu, 25 Jun 2026 18:29:55 +0200 [thread overview]
Message-ID: <2958cbbe-de8d-4156-ba7c-a500ff364cdc@gmx.de> (raw)
In-Reply-To: <20260625030102.79755-1-pengpeng@iscas.ac.cn>
On 6/25/26 05:01, Pengpeng Hou wrote:
> goldfish_fb_pan_display() waits for the device to acknowledge the new
> framebuffer base, but it only logs a timeout and still reports success.
> The probe path also ignores the initial pan-display result before
> registering the framebuffer.
>
> Return -ETIMEDOUT when the base-update acknowledgment does not arrive,
> and propagate that error from the initial probe-time base update before
> the framebuffer is published.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/video/fbdev/goldfishfb.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
applied.
Thanks!
Helge
prev parent reply other threads:[~2026-06-25 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 3:01 [PATCH] fbdev: goldfishfb: fail pan display on base-update timeout Pengpeng Hou
2026-06-25 16:29 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2958cbbe-de8d-4156-ba7c-a500ff364cdc@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox