* [PATCH RESEND] fbdev: omapfb: remove unused variable @ 2017-07-26 13:57 ` Arnd Bergmann 2017-07-26 14:27 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 5+ messages in thread From: Arnd Bergmann @ 2017-07-26 13:57 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev, Arnd Bergmann, linux-kernel, dri-devel, Tomi Valkeinen, Laurent Pinchart, linux-omap Removing the default display name left a harmless warning: fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] This removes the now-unused variable as well. Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Originally submitted on June 9, no reply other than the Reviewed-by tag. The patch is still needed --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index eecf695c16f4..09e5bb013d28 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - struct omap_dss_board_info *pdata = pdev->dev.platform_data; int r; core.pdev = pdev; -- 2.9.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] fbdev: omapfb: remove unused variable 2017-07-26 13:57 ` [PATCH RESEND] fbdev: omapfb: remove unused variable Arnd Bergmann @ 2017-07-26 14:27 ` Bartlomiej Zolnierkiewicz 2017-07-26 14:31 ` Arnd Bergmann 2017-07-31 16:38 ` Bartlomiej Zolnierkiewicz 0 siblings, 2 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-07-26 14:27 UTC (permalink / raw) To: Arnd Bergmann Cc: dri-devel, Tomi Valkeinen, Laurent Pinchart, linux-omap, linux-fbdev, linux-kernel Hi, On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote: > Removing the default display name left a harmless warning: > > fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': > fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] > > This removes the now-unused variable as well. > > Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Originally submitted on June 9, no reply other than the Reviewed-by tag. > The patch is still needed It is not lost and will be queued for 4.13 fbdev fixes pull request. [ The guilty commit went through DRM tree and pulling it into fbdev tree just to fix the warning was not feasible.. ] > --- > drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c > index eecf695c16f4..09e5bb013d28 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c > @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = { > > static int __init omap_dss_probe(struct platform_device *pdev) > { > - struct omap_dss_board_info *pdata = pdev->dev.platform_data; > int r; > > core.pdev = pdev; Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] fbdev: omapfb: remove unused variable 2017-07-26 14:27 ` Bartlomiej Zolnierkiewicz @ 2017-07-26 14:31 ` Arnd Bergmann 2017-07-26 14:50 ` Daniel Vetter 2017-07-31 16:38 ` Bartlomiej Zolnierkiewicz 1 sibling, 1 reply; 5+ messages in thread From: Arnd Bergmann @ 2017-07-26 14:31 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev, Linux Kernel Mailing List, dri-devel, Tomi Valkeinen, Laurent Pinchart, linux-omap On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > Hi, > > On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote: >> Removing the default display name left a harmless warning: >> >> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': >> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] >> >> This removes the now-unused variable as well. >> >> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> --- >> Originally submitted on June 9, no reply other than the Reviewed-by tag. >> The patch is still needed > > It is not lost and will be queued for 4.13 fbdev fixes pull request. Ok, thanks a lot! > [ The guilty commit went through DRM tree and pulling it into fbdev > tree just to fix the warning was not feasible.. ] Yes, I was originally hoping the fix could be merged along with the patch that introduced the bug. I may have messed up the Cc list for that though. Arnd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] fbdev: omapfb: remove unused variable 2017-07-26 14:31 ` Arnd Bergmann @ 2017-07-26 14:50 ` Daniel Vetter 0 siblings, 0 replies; 5+ messages in thread From: Daniel Vetter @ 2017-07-26 14:50 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Linux Kernel Mailing List, dri-devel, Tomi Valkeinen, Laurent Pinchart, linux-omap On Wed, Jul 26, 2017 at 04:31:38PM +0200, Arnd Bergmann wrote: > On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: > > > > Hi, > > > > On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote: > >> Removing the default display name left a harmless warning: > >> > >> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': > >> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] > >> > >> This removes the now-unused variable as well. > >> > >> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> --- > >> Originally submitted on June 9, no reply other than the Reviewed-by tag. > >> The patch is still needed > > > > It is not lost and will be queued for 4.13 fbdev fixes pull request. > > Ok, thanks a lot! > > > [ The guilty commit went through DRM tree and pulling it into fbdev > > tree just to fix the warning was not feasible.. ] > > Yes, I was originally hoping the fix could be merged along with the > patch that introduced the bug. I may have messed up the Cc list for that > though. Should we add dri-devel as an mailing list entry to the fbdev system in MAINTAINERS? Iirc there's almost no traffic for fbdev itself, and this would avoid such a fumble in the future. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] fbdev: omapfb: remove unused variable 2017-07-26 14:27 ` Bartlomiej Zolnierkiewicz 2017-07-26 14:31 ` Arnd Bergmann @ 2017-07-31 16:38 ` Bartlomiej Zolnierkiewicz 1 sibling, 0 replies; 5+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-07-31 16:38 UTC (permalink / raw) To: Arnd Bergmann Cc: linux-fbdev, linux-kernel, dri-devel, Tomi Valkeinen, Laurent Pinchart, linux-omap On Wednesday, July 26, 2017 04:27:30 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote: > > Removing the default display name left a harmless warning: > > > > fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': > > fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable] > > > > This removes the now-unused variable as well. > > > > Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > Originally submitted on June 9, no reply other than the Reviewed-by tag. > > The patch is still needed > > It is not lost and will be queued for 4.13 fbdev fixes pull request. > > [ The guilty commit went through DRM tree and pulling it into fbdev > tree just to fix the warning was not feasible.. ] Patch queued for 4.13, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-31 16:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170726135825epcas4p3c5326b3893927c4be0db0fde076d0799@epcas4p3.samsung.com>
2017-07-26 13:57 ` [PATCH RESEND] fbdev: omapfb: remove unused variable Arnd Bergmann
2017-07-26 14:27 ` Bartlomiej Zolnierkiewicz
2017-07-26 14:31 ` Arnd Bergmann
2017-07-26 14:50 ` Daniel Vetter
2017-07-31 16:38 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).