* [PATCH V4 4/4] fbcon: queue work on unbound wq @ 2013-03-31 14:39 Viresh Kumar 0 siblings, 0 replies; 2+ messages in thread From: Viresh Kumar @ 2013-03-31 14:39 UTC (permalink / raw) To: linux-fbdev fbcon uses workqueues and it has no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one. This patch replaces system_wq with system_unbound_wq. Cc: Dave Airlie <airlied@redhat.com> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/video/console/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 3cd6759..6c1f7c3 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -404,7 +404,7 @@ static void cursor_timer_handler(unsigned long dev_addr) struct fb_info *info = (struct fb_info *) dev_addr; struct fbcon_ops *ops = info->fbcon_par; - schedule_work(&info->queue); + queue_work(system_unbound_wq, &info->queue); mod_timer(&ops->cursor_timer, jiffies + HZ/5); } -- 1.7.12.rc2.18.g61b472e ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <cover.1364740180.git.viresh.kumar@linaro.org>]
* [PATCH V4 4/4] fbcon: queue work on unbound wq [not found] <cover.1364740180.git.viresh.kumar@linaro.org> @ 2013-03-31 14:43 ` Viresh Kumar 0 siblings, 0 replies; 2+ messages in thread From: Viresh Kumar @ 2013-03-31 14:43 UTC (permalink / raw) To: tj Cc: linaro-kernel, patches, robin.randhawa, Steve.Bannister, Liviu.Dudau, charles.garcia-tobin, arvind.chauhan, davem, airlied, axboe, tglx, peterz, mingo, rostedt, linux-rt-users, linux-kernel, Viresh Kumar, linux-fbdev fbcon uses workqueues and it has no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one. This patch replaces system_wq with system_unbound_wq. Cc: Dave Airlie <airlied@redhat.com> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/video/console/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 3cd6759..6c1f7c3 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -404,7 +404,7 @@ static void cursor_timer_handler(unsigned long dev_addr) struct fb_info *info = (struct fb_info *) dev_addr; struct fbcon_ops *ops = info->fbcon_par; - schedule_work(&info->queue); + queue_work(system_unbound_wq, &info->queue); mod_timer(&ops->cursor_timer, jiffies + HZ/5); } -- 1.7.12.rc2.18.g61b472e ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-31 14:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-31 14:39 [PATCH V4 4/4] fbcon: queue work on unbound wq Viresh Kumar
[not found] <cover.1364740180.git.viresh.kumar@linaro.org>
2013-03-31 14:43 ` Viresh Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).