From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA45C433EF for ; Mon, 9 May 2022 20:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbiEIUKJ (ORCPT ); Mon, 9 May 2022 16:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238790AbiEIUIl (ORCPT ); Mon, 9 May 2022 16:08:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BF7FB24BB08 for ; Mon, 9 May 2022 13:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652126630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qnTkUabpe7jRtYxC0JIcCJ58YEOMuCVoeEj+uJ3yZCs=; b=cQo5gusFlh/xsHPpTPYHs9BKzG02sYtAyWygAHUPqD4uWGIDYqo1/OQQ0ocS79ORVv3PMJ WvIRHd/aqK4II/mC8rpPcNRtVC8HHr3vZHe0VSowUqGbpdPa2r8bnaD9L5n0EEu/JlkLT7 M78HxKFMNg6iuamqEUMQEZ6PGoR8fM8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-386-NhmAITt0OmGfBkeg1C_tlA-1; Mon, 09 May 2022 16:03:49 -0400 X-MC-Unique: NhmAITt0OmGfBkeg1C_tlA-1 Received: by mail-wr1-f71.google.com with SMTP id p10-20020adfaa0a000000b0020c4829af5fso6201104wrd.16 for ; Mon, 09 May 2022 13:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qnTkUabpe7jRtYxC0JIcCJ58YEOMuCVoeEj+uJ3yZCs=; b=j78eO+KmGxoFrs0KJRlohv0rqrkeD7Bf+9IthzkRunlkc6vP6gyT4RydjZX2SzVvo4 17FZhbwNAZbwupSn5hMimXI4jkb7d6azzhEdq2AyHIJu+07VshJlPE+9n080C8rFZVmx e5rY5nE7igHRKFW6nANTHWyAbUS4z9X7HBP4wklk/27swSTW8S7EBhJXGzsB6f7eS249 YXm+Zq1/ORq3NSFNQZVR7iIe9tOEp9Og/AV0IzDmXgyxjIv4BfG+fvY01i9aZuQQalxs q2xtYQWOafVMJ8fqA/xqsbjg7L5BSsbrZdoyivBRIlJLaFgm40Y0/qRJgqOIVuo1oCgP 98fw== X-Gm-Message-State: AOAM530+XrM3vUE30CcTegmJ+83WxNCSzBJ7tsGDdQPR1FRdpXYZ5en6 mnsxdXaHSy5PIs/H17Em2XV8zqjkUlOVM2VZNAFJgBveuK3NI+hoJirWBg8FvmnuqqHLu2diGn4 9/PmD2rLPYg15RQADkoIG4rE= X-Received: by 2002:a05:600c:ada:b0:394:30f0:5b24 with SMTP id c26-20020a05600c0ada00b0039430f05b24mr17757049wmr.57.1652126628259; Mon, 09 May 2022 13:03:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXbnXq4q4M+gBT0G+FQfJ/08vE6H+CMK+PCG9aU5sZFTb8/Iev3kbWSsbfQd4TXLWBeAhjBA== X-Received: by 2002:a05:600c:ada:b0:394:30f0:5b24 with SMTP id c26-20020a05600c0ada00b0039430f05b24mr17757018wmr.57.1652126627950; Mon, 09 May 2022 13:03:47 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id k8-20020adfd848000000b0020c5253d8dbsm11555562wrl.39.2022.05.09.13.03.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 May 2022 13:03:47 -0700 (PDT) Message-ID: <2bf27b09-0896-1849-254f-d5b19abdc892@redhat.com> Date: Mon, 9 May 2022 22:03:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release() Content-Language: en-US To: Thomas Zimmermann , Andrzej Hajda , linux-kernel@vger.kernel.org Cc: linux-fbdev@vger.kernel.org, Daniel Vetter , Helge Deller , dri-devel@lists.freedesktop.org, Daniel Vetter References: <20220505215947.364694-1-javierm@redhat.com> <20220505220413.365977-1-javierm@redhat.com> <753d0350-42dc-389b-b10b-4533ddcf32ac@intel.com> <1f788b8f-0bea-1818-349e-b1bc907bf251@redhat.com> <3b7fe4fe-fdec-cef2-4e0e-309d9dc4a8af@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 5/9/22 20:12, Thomas Zimmermann wrote: [snip] >> I actually thought about the same but then remembered what Daniel said in [0] >> (AFAIU at least) that these should be done in .remove() so the current code >> looks like matches that and only framebuffer_release() should be moved. >> >> For vesafb a previous patch proposed to also move a release_region() call to >> .fb_destroy() and Daniel also said that it was iffy and shouldn't be done [1]. >> >> But I'm also not fb expert so happy to move fb_dealloc_cmap() as well if that >> is the correct thing to do. > > The cmap data structure is software state that can be accessed via icotl > as long as the devfile is open. Drivers update the hardware from it. See > [1]. Moving that cleanup into fb_destroy seems appropriate to me. > I see, that makes sense. Then something like the following instead? diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index d265a73313c9..ce0d89c49e42 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -627,12 +627,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper) cancel_work_sync(&fb_helper->resume_work); cancel_work_sync(&fb_helper->damage_work); - info = fb_helper->fbdev; - if (info) { - if (info->cmap.len) - fb_dealloc_cmap(&info->cmap); - framebuffer_release(info); - } fb_helper->fbdev = NULL; mutex_lock(&kernel_fb_helper_lock); @@ -2111,7 +2105,11 @@ static void drm_fbdev_release(struct drm_fb_helper *fb_helper) */ static void drm_fbdev_fb_destroy(struct fb_info *info) { + if (info->cmap.len) + fb_dealloc_cmap(&info->cmap); + drm_fbdev_release(info->par); + framebuffer_release(info); } static int drm_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat