From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Date: Fri, 02 Aug 2019 22:32:33 +0000 Subject: Re: [PATCH 03/34] net/ceph: convert put_page() to put_user_page*() Message-Id: <2f0d5993e9731808b73b0018f5fc4b3335fc6373.camel@kernel.org> List-Id: References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802022005.5117-4-jhubbard@nvidia.com> In-Reply-To: <20190802022005.5117-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: john.hubbard@gmail.com, Andrew Morton Cc: Christoph Hellwig , Dan Williams , Dave Chinner , Dave Hansen , Ira Weiny , Jan Kara , Jason Gunthorpe , =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , LKML , amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org, devel@lists.orangefs.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org On Thu, 2019-08-01 at 19:19 -0700, john.hubbard@gmail.com wrote: > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Ilya Dryomov > Cc: Sage Weil > Cc: David S. Miller > Cc: ceph-devel@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: John Hubbard > --- > net/ceph/pagevec.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c > index 64305e7056a1..c88fff2ab9bd 100644 > --- a/net/ceph/pagevec.c > +++ b/net/ceph/pagevec.c > @@ -12,13 +12,7 @@ > > void ceph_put_page_vector(struct page **pages, int num_pages, bool dirty) > { > - int i; > - > - for (i = 0; i < num_pages; i++) { > - if (dirty) > - set_page_dirty_lock(pages[i]); > - put_page(pages[i]); > - } > + put_user_pages_dirty_lock(pages, num_pages, dirty); > kvfree(pages); > } > EXPORT_SYMBOL(ceph_put_page_vector); This patch looks sane enough. Assuming that the earlier patches are OK: Acked-by: Jeff Layton