From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: pebolle@tiscali.nl, Hans de Goede <j.w.r.degoede@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kbuild@vger.kernel.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Michal Simek <michal.simek@xilinx.com>,
yamada.masahiro@socionext.com, mcgrof@kernel.org,
linux-fbdev@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH 02/11] video: fbdev: kconfig: Remove blank help text
Date: Thu, 01 Feb 2018 15:52:42 +0000 [thread overview]
Message-ID: <3132455.r9uCTL3ZTk@amdc3058> (raw)
In-Reply-To: <20180131093434.20050-3-ulfalizer@gmail.com>
Hi,
On Wednesday, January 31, 2018 10:34:21 AM Ulf Magnusson wrote:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
How about actually adding some meaningful help texts instead
(as a general rule each user visible option should have valid
help text)?
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> drivers/video/fbdev/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 6962b4583fd7..11e699f1062b 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1156,7 +1156,6 @@ config FB_I810_I2C
> bool "Enable DDC Support"
> depends on FB_I810 && FB_I810_GTF
> select FB_DDC
> - help
Please add a missing help text instead (take a look at FB_SAVAGE_I2C
config option to see how a valid help text entry should look like).
In the longer term we should consider removing *_I2C config options
and just make the main config options always enable I2C subsystem
directly if needed/useful (some fbdev drivers are doing it this way
already).
> config FB_LE80578
> tristate "Intel LE80578 (Vermilion) support"
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2018-02-01 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180131093434.20050-1-ulfalizer@gmail.com>
2018-01-31 9:34 ` [PATCH 02/11] video: fbdev: kconfig: Remove blank help text Ulf Magnusson
2018-02-01 15:52 ` Bartlomiej Zolnierkiewicz [this message]
2018-02-01 16:56 ` Ulf Magnusson
2018-02-01 17:07 ` Masahiro Yamada
[not found] ` <CGME20180213123147epcas2p2a2bb399e700dacef57a2340afcc0e459@epcas2p2.samsung.com>
2018-02-13 12:31 ` Bartlomiej Zolnierkiewicz
2018-02-13 14:02 ` [PATCH] video: fbdev: kconfig: Add help text to FB_I810_I2C Ulf Magnusson
[not found] ` <CGME20180312150855epcas1p36b1377471a2a0d69362fa3cf57295209@epcas1p3.samsung.com>
2018-03-12 15:08 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3132455.r9uCTL3ZTk@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.w.r.degoede@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pebolle@tiscali.nl \
--cc=rdunlap@infradead.org \
--cc=ulfalizer@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).