From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: "Pieter \"PoroCYon\" Sluys" <pcy@national.shitposting.agency>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] vfb: fix video mode and line_length being set when loaded
Date: Thu, 04 Jan 2018 15:05:15 +0000 [thread overview]
Message-ID: <3149875.iSmVjzXX7W@amdc3058> (raw)
In-Reply-To: <81bf0d1e-ee7a-29ea-d19e-ffeb41d285fe@national.shitposting.agency>
On Wednesday, December 20, 2017 02:53:00 PM Pieter PoroCYon Sluys wrote:
> Geert Uytterhoeven:
> > Please add your "Signed-off-by", cfr.
> > Documentation/process/submitting-patches.rst.
>
> Sorry I knew I would've messed up *something*.
>
> > You can drop the tests for 2 and 4, as these are no longer used by the driver.
>
> Done that.
>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Pieter "PoroCYon" Sluys <pcy@national.shitposting.agency>
I've queued your patch for 4.16 kernel (after fixing few minor
issues [*]), thanks!
[*] next time please remember to:
* always include full patch description in the later patch revisions
* put things that don't belong to patch description after "---" so
they will not be included in the final commit
* in the later patch revisions include ChangeLog after "---" and also
put patch version in the patch summary line / mail subject
(i.e. "[PATCH v2] ...")
* add tags (i.e. "Reviewed-by: ...") from patch reviewers / testers
into the patch description
* check your patch with scripts/checkpatch.pl tool and fix reported
issues, i.e.:
ERROR: switch and case should be at the same indent
#69: FILE: drivers/video/fbdev/vfb.c:242:
+ switch (info->var.bits_per_pixel) {
+ case 1:
[...]
+ case 8:
[...]
+ case 16:
+ case 24:
+ case 32:
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2018-01-04 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 0:24 [PATCH] vfb: fix video mode and line_length being set when loaded Pieter "PoroCYon" Sluys
2017-12-20 8:26 ` Geert Uytterhoeven
2017-12-20 14:53 ` Pieter "PoroCYon" Sluys
2018-01-04 15:05 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3149875.iSmVjzXX7W@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pcy@national.shitposting.agency \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).