From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Mon, 07 Aug 2017 15:11:48 +0000 Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable Message-Id: <3387426.dX5mCNm2tR@amdc3058> List-Id: References: <20170802093722.3666961-1-arnd@arndb.de> In-Reply-To: <20170802093722.3666961-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: Daniel Vetter , Dan Carpenter , Sean Paul , Arvind Yadav , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday, August 02, 2017 11:36:47 AM Arnd Bergmann wrote: > The variable has become unused in modular configurations > which triggers a harmless warning: > > drivers/video/fbdev/matrox/matroxfb_base.c:1583:12: error: 'hotplug' defined but not used [-Werror=unused-variable] > > This moves it into an #ifdef section of the file, matching > all its references. > > Fixes: 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE") > Signed-off-by: Arnd Bergmann Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics