* [PATCH] omapfb: constify omap_video_timings structures
@ 2017-08-12 6:20 ` Julia Lawall
2017-08-21 14:48 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2017-08-12 6:20 UTC (permalink / raw)
To: Tomi Valkeinen
Cc: kernel-janitors, Bartlomiej Zolnierkiewicz, linux-omap,
linux-fbdev, linux-kernel, Bhumika Goyal
These omap_video_timings structures are only copied into other
structures, so they can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 2 +-
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
index f14691c..6cd759c 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
@@ -18,7 +18,7 @@
#include <video/omapfb_dss.h>
-static struct omap_video_timings lb035q02_timings = {
+static const struct omap_video_timings lb035q02_timings = {
.x_res = 320,
.y_res = 240,
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
index b529a8c..57e9e14 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
@@ -41,7 +41,7 @@ struct panel_drv_data {
struct spi_device *spi_dev;
};
-static struct omap_video_timings td028ttec1_panel_timings = {
+static const struct omap_video_timings td028ttec1_panel_timings = {
.x_res = 480,
.y_res = 640,
.pixelclock = 22153000,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omapfb: constify omap_video_timings structures
2017-08-12 6:20 ` [PATCH] omapfb: constify omap_video_timings structures Julia Lawall
@ 2017-08-21 14:48 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-21 14:48 UTC (permalink / raw)
To: Julia Lawall
Cc: Tomi Valkeinen, kernel-janitors, linux-omap, linux-fbdev,
linux-kernel, Bhumika Goyal
On Saturday, August 12, 2017 08:20:36 AM Julia Lawall wrote:
> These omap_video_timings structures are only copied into other
> structures, so they can be const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-21 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170812064614epcas2p2dee0d2e45189a2bb6753b40ca99321a1@epcas2p2.samsung.com>
2017-08-12 6:20 ` [PATCH] omapfb: constify omap_video_timings structures Julia Lawall
2017-08-21 14:48 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).