From: Helge Deller <deller@gmx.de>
To: Felix Gu <ustc.gu@gmail.com>, Zhang Shurong <zhang_shurong@foxmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: au1200fb: Fix a memory leak in au1200fb_drv_probe()
Date: Fri, 6 Feb 2026 20:32:20 +0100 [thread overview]
Message-ID: <3439df9e-5f29-4628-9e5f-dddbce0831f9@gmx.de> (raw)
In-Reply-To: <20260203-au1200fb-v1-1-7889c4061337@gmail.com>
On 2/3/26 13:14, Felix Gu wrote:
> In au1200fb_drv_probe(), when platform_get_irq fails(), it directly
> returns from the function with an error code, which causes a memory
> leak.
>
> Replace it with a goto label to ensure proper cleanup.
>
> Fixes: 4e88761f5f8c ("fbdev: au1200fb: Fix missing IRQ check in au1200fb_drv_probe")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/video/fbdev/au1200fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
applied.
Thanks!
Helge
prev parent reply other threads:[~2026-02-06 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 12:14 [PATCH] fbdev: au1200fb: Fix a memory leak in au1200fb_drv_probe() Felix Gu
2026-02-06 19:32 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3439df9e-5f29-4628-9e5f-dddbce0831f9@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ustc.gu@gmail.com \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox