linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] fbdev: sh_mobile_lcdc: fixup B side hsync adjust settings
Date: Tue, 05 Mar 2013 15:45:46 +0000	[thread overview]
Message-ID: <3616474.9Jo4TxL1sT@avalon> (raw)
In-Reply-To: <87txoqmo3p.wl%kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

Thanks for the patch.

On Monday 04 March 2013 21:07:10 Kuninori Morimoto wrote:
> The lcdc B side horizon output is shifted
> if sh_mobile_lcdc_pan() was called.
> This patch fixup this issue.
> It is tested on R8A7740 Armadillo800eva HDMI output.
> Special thanks to Fukushima-san, and Sano-san
> 
> Reported-by: Osamu Fukushima <osamu.fukushima.wr@renesas.com>
> Signed-off-by: Hideyuki Sano <hideyuki.sano.dn@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v1 -> v2
> 
>  - git log has tested SoC/board
> 
>  drivers/video/sh_mobile_lcdcfb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/sh_mobile_lcdcfb.c
> b/drivers/video/sh_mobile_lcdcfb.c index 63203ac..0264704 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -858,6 +858,7 @@ static void sh_mobile_lcdc_geometry(struct
> sh_mobile_lcdc_chan *ch) tmp = ((mode->xres & 7) << 24) | ((display_h_total
> & 7) << 16)
> 
>  	    | ((mode->hsync_len & 7) << 8) | (hsync_pos & 7);
> 
>  	lcdc_write_chan(ch, LDHAJR, tmp);
> +	lcdc_write_chan_mirror(ch, LDHAJR, tmp);
>  }
> 
>  static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay
> *ovl)

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-03-05 15:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  5:07 [PATCH v2] fbdev: sh_mobile_lcdc: fixup B side hsync adjust settings Kuninori Morimoto
2013-03-05 15:45 ` Laurent Pinchart [this message]
2013-03-19  4:19 ` Simon Horman
2013-03-19 12:38 ` Laurent Pinchart
2013-03-25  7:33 ` Kuninori Morimoto
2013-03-26 13:19 ` Simon Horman
2013-03-26 23:56 ` Kuninori Morimoto
2013-03-27  6:03 ` Simon Horman
2013-03-27  6:08 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3616474.9Jo4TxL1sT@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).