Re: [PATCH] Fonts: New Terminus large console font

Re: [PATCH] Fonts: New Terminus large console font

[Greg KH]

On Sun, Nov 25, 2018 at 10:47:34PM -0500, nimrud wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.
> 
> Signed-off-by: Amanoel Dawod <amanoeladawod@gmail.com>
> ---
>  include/linux/font.h      |    8 +-
>  lib/fonts/Kconfig         |   10 +
>  lib/fonts/Makefile        |    1 +
>  lib/fonts/font_ter16x32.c | 2072 +++++++++++++++++++++++++++++++++++++
>  lib/fonts/fonts.c         |    4 +
>  5 files changed, 2092 insertions(+), 3 deletions(-)
>  create mode 100644 lib/fonts/font_ter16x32.c
> 
> diff --git a/include/linux/font.h b/include/linux/font.h
> index d6821769dd1e..8ab5192e8a13 100644
> --- a/include/linux/font.h
> +++ b/include/linux/font.h
> @@ -29,9 +29,10 @@ struct font_desc {
>  #define	FONT10x18_IDX	5
>  #define SUN8x16_IDX	6
>  #define SUN12x22_IDX	7
> -#define ACORN8x8_IDX	8
> -#define	MINI4x6_IDX	9
> -#define FONT6x10_IDX	10
> +#define TER16x32_IDX	8
> +#define ACORN8x8_IDX	9
> +#define	MINI4x6_IDX	10
> +#define FONT6x10_IDX	11

By changing the font names, did you just break anything?  Why not just
add your new one at the end of the list?

thanks,

greg k-h

Re: [PATCH] Fonts: New Terminus large console font

[Greg KH]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Mon, Nov 26, 2018 at 03:09:31AM -0500, Amanoel Dawod wrote:
> Changing the name did not break anything. Pretty much I dumped the original
> .psf file to .inc
> format with new naming using psftools extracting the bitmap data. Then
> manually editing it
> removing useless header, leaving bitmaps data alone.

I did not refer to any name, just the #define that you changed.

> Do you mean adding it at end of lists with other fonts? if that's what you
> mean,
> no real reason, but just wanted it to be after sun12x22 always as in
> Kconfig.

You can put it wherever you want in the Kconfig file (but you should put
it at the end, as it is a new font.)  I mean the #defines, you need to
just add it at the end please, do not change any existing #defines.


> Please let me know if that must be changed.
> Now regarding "From:" line, please accept my apology as it my first time
> dealing
> with submissions and git send-mail. Should I re-submit the patch with
> modified subject line?

Not subject line, From: line from your email client.  And you need to
change the patch anyway before it could be added, so you have to resend
it :)

thanks,

greg k-h

Re: [PATCH] Fonts: New Terminus large console font

[Greg KH]

On Sun, Nov 25, 2018 at 10:47:34PM -0500, nimrud wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.
> 
> Signed-off-by: Amanoel Dawod <amanoeladawod@gmail.com>

Also, your "From:" line on your email does not match this name, so that
needs to be fixed before we could take the patch :(

thanks,

greg k-h

Re: [PATCH] Fonts: New Terminus large console font

[Lubomir Rintel]

Hi.

On Sun, 2018-11-25 at 22:47 -0500, nimrud wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.
> 
> Signed-off-by: Amanoel Dawod <amanoeladawod@gmail.com>

I've wished for a 15x30 font for quite some time, because that would
look good on an OLPC laptop screen that's 19cm (7.5") at 1200x900. A
15x30 would give me 80x30 characters, while a 16x32 would give me
somewhat less practical 75x28 with extra space around.

I'm wondering what resolutions are you targetting? Perhaps a 30x15
would do just as well, and if we need an 32x16, then we could perhaps
just add an ability to scale one of the existing fonts by a factor of
2.

Cheers
Lubo

Re: [PATCH] Fonts: New Terminus large console font

[Greg KH]

On Mon, Nov 26, 2018 at 04:21:15AM -0500, Amanoel Dawod wrote:
> This patch adds an option to compile-in a high resolution and large
> Terminus (ter16x32) bitmap console font for use with HiDPI and Retina screens.
> 
> The font was convereted from standard Terminus ter-i32b.psf (size 16x32)
> with the help of psftools and minor hand editing deleting useless characters.
> 
> This patch is non-intrusive, no options are enabled by default so most
> users won't notice a thing.
> 
> I am placing my changes under the GPL 2.0 just as source Terminus font.

Can you please run scripts/checkpatch.pl and fix up the issues that it
finds in this patch.  It's a lot:
	total: 1792 errors, 2058 warnings, 2127 lines checked

thanks,

greg k-h