From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Mon, 03 Jun 2013 19:54:39 +0000 Subject: Re: [PATCH] PM: Add pm_sleep_ops_ptr() macro Message-Id: <3772829.L58vmUyOpk@vostro.rjw.lan> List-Id: References: <002801ce6022$a2928930$e7b79b90$@samsung.com> <1867006.c6mxKpbPvX@vostro.rjw.lan> In-Reply-To: <1867006.c6mxKpbPvX@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jingoo Han Cc: 'Jean-Christophe PLAGNIOL-VILLARD' , 'Lars-Peter Clausen' , 'Michael Hennerich' , 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org On Monday, June 03, 2013 01:11:07 PM Rafael J. Wysocki wrote: > On Monday, June 03, 2013 03:21:51 PM Jingoo Han wrote: > > Add pm_sleep_ops_ptr() macro that allows the .pm entry in the driver structures > > to be assigned without having an #define xxx NULL for the case that PM_SLEEP is > > not enabled. > > > > Signed-off-by: Jingoo Han > > Cc: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Lars-Peter Clausen > > Cc: Tomi Valkeinen > > Cc: Michael Hennerich > > Do you want me to replace the previous patch with this? Quite frankly, I prefer the previous version, which was more general. That is, what if someone wants to use that macro for runtime PM too? Honestly, I think we'll be better off without any of them, so I'm dropping the previous patch too for now. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.