From: Dan Carpenter <dan.carpenter@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Helge Deller" <deller@gmx.de>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sekhar Nori" <nsekhar@ti.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] fbdev/da8xx-fb: unlock on error paths in suspend/resume
Date: Fri, 11 Oct 2024 22:42:28 +0300 [thread overview]
Message-ID: <37842441-e372-40e9-b0f5-cf69defc2db5@stanley.mountain> (raw)
Add a missing console_unlock() in the suspend and resume functions on
the error paths.
Fixes: 611097d5daea ("fbdev: da8xx: add support for a regulator")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/video/fbdev/da8xx-fb.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/da8xx-fb.c b/drivers/video/fbdev/da8xx-fb.c
index fad1e13c6332..66ff8456b231 100644
--- a/drivers/video/fbdev/da8xx-fb.c
+++ b/drivers/video/fbdev/da8xx-fb.c
@@ -1610,8 +1610,10 @@ static int fb_suspend(struct device *dev)
console_lock();
if (par->lcd_supply) {
ret = regulator_disable(par->lcd_supply);
- if (ret)
+ if (ret) {
+ console_unlock();
return ret;
+ }
}
fb_set_suspend(info, 1);
@@ -1636,8 +1638,10 @@ static int fb_resume(struct device *dev)
if (par->lcd_supply) {
ret = regulator_enable(par->lcd_supply);
- if (ret)
+ if (ret) {
+ console_unlock();
return ret;
+ }
}
}
--
2.45.2
next reply other threads:[~2024-10-11 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 19:42 Dan Carpenter [this message]
2024-10-14 7:06 ` [PATCH] fbdev/da8xx-fb: unlock on error paths in suspend/resume Bartosz Golaszewski
2024-10-14 7:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37842441-e372-40e9-b0f5-cf69defc2db5@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=brgl@bgdev.pl \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox