From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Martin Kaiser" <martin@kaiser.cx>
Cc: Sascha Hauer <kernel@pengutronix.de>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] video: imxfb: remove the macros for initializing the DMACR
Date: Wed, 11 Jan 2017 12:39:58 +0000 [thread overview]
Message-ID: <3888193.7ysKGrrrC4@amdc3058> (raw)
In-Reply-To: <20161129195721.rwlals7tzusprzpz@pengutronix.de>
Hi,
On Tuesday, November 29, 2016 08:57:21 PM Uwe Kleine-König wrote:
> On Tue, Nov 29, 2016 at 08:50:39PM +0100, Martin Kaiser wrote:
> > The current definitions of DMACR_HM() and DMACR_TM() are correct only
> > for imx1, they're wrong for imx21.
> >
> > The macros are meant for legacy board files only, they're not applicable
> > for boards using device tree.
> >
> > At the moment, there are no boards using these macros. So it should be
> > safe to drop them rather than making them work for both imx1 and imx21,
> > which would require a change in the platform data struct.
> >
> > Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks, queued for 4.11.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-01-11 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 7:54 [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser
2016-11-22 8:42 ` Uwe Kleine-König
2016-11-23 9:31 ` Martin Kaiser
2016-11-23 9:50 ` Uwe Kleine-König
2016-11-25 8:43 ` Martin Kaiser
2016-11-28 22:43 ` [PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser
2016-11-29 7:49 ` Uwe Kleine-König
2016-11-29 19:50 ` [PATCH v2] " Martin Kaiser
2016-11-29 19:57 ` Uwe Kleine-König
[not found] ` <CGME20170111124006epcas5p138afe03766a09b68eac3f93a9047ee27@epcas5p1.samsung.com>
2017-01-11 12:39 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3888193.7ysKGrrrC4@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).