From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 11 Jan 2017 12:39:58 +0000 Subject: Re: [PATCH v2] video: imxfb: remove the macros for initializing the DMACR Message-Id: <3888193.7ysKGrrrC4@amdc3058> List-Id: References: <20161129074949.taj5bwnhge37pi5e@pengutronix.de> <1480449039-14774-1-git-send-email-martin@kaiser.cx> <20161129195721.rwlals7tzusprzpz@pengutronix.de> In-Reply-To: <20161129195721.rwlals7tzusprzpz@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Martin Kaiser Cc: Sascha Hauer , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Hi, On Tuesday, November 29, 2016 08:57:21 PM Uwe Kleine-K=F6nig wrote: > On Tue, Nov 29, 2016 at 08:50:39PM +0100, Martin Kaiser wrote: > > The current definitions of DMACR_HM() and DMACR_TM() are correct only > > for imx1, they're wrong for imx21. > >=20 > > The macros are meant for legacy board files only, they're not applicable > > for boards using device tree. > >=20 > > At the moment, there are no boards using these macros. So it should be > > safe to drop them rather than making them work for both imx1 and imx21, > > which would require a change in the platform data struct. > >=20 > > Signed-off-by: Martin Kaiser > Acked-by: Uwe Kleine-K=F6nig Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics