linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* fb_cmap and transparency
@ 2003-03-18 14:34 Geert Uytterhoeven
  2003-03-18 17:21 ` James Simmons
  2003-03-18 21:58 ` Programmers documetnation on framebuffer console? Kendall Bennett
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2003-03-18 14:34 UTC (permalink / raw)
  To: James Simmons, Linux Frame Buffer Device Development


If a colormap contains no transparency information, fb_set_cmap() calls
fb_setcolreg() with trans = 0. This causes all CLUT entries to be fully
transparent on hardware that does have transparency information in the CLUT
registers.

The following patch solves this problem by changing the default transparency
from 0 (full transparent) to 0xffff (full opaque).

The patch applies to both 2.4.20 and 2.5.65.

--- linux/drivers/video/fbcmap.c.orig	Mon Mar  5 09:29:30 2001
+++ linux/drivers/video/fbcmap.c	Mon Mar 17 17:39:59 2003
@@ -271,7 +271,7 @@
 	    hred = *red;
 	    hgreen = *green;
 	    hblue = *blue;
-	    htransp = transp ? *transp : 0;
+	    htransp = transp ? *transp : 0xffff;
 	} else {
 	    get_user(hred, red);
 	    get_user(hgreen, green);
@@ -279,7 +279,7 @@
 	    if (transp)
 		get_user(htransp, transp);
 	    else
-		htransp = 0;
+		htransp = 0xffff;
 	}
 	red++;
 	green++;

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This SF.net email is sponsored by: Does your code think in ink? 
You could win a Tablet PC. Get a free Tablet PC hat just for playing. 
What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2003-03-19  3:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-18 14:34 fb_cmap and transparency Geert Uytterhoeven
2003-03-18 17:21 ` James Simmons
2003-03-18 21:58 ` Programmers documetnation on framebuffer console? Kendall Bennett
2003-03-19  3:39   ` Richard Drummond

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).