Re: 2.6 fbcon and 15/16 bpp

[John Zielinski <grim@undead.cc>]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Benjamin Herrenschmidt wrote:

>Well, the interesting thing is does X using "fbdev" has proper colors
>(or X using "ati" driver with UseFBDev option). If yes, then that code
>is right. It's the console/blit code that is wrong.
>  
>
Confirmed using fbtest.  With that section commented out fbtest's colors 
are messed up.

Hmmm....  Just found something.  Here's an updated patch.  Notice the 6 
changing to a 5 in the 16 bit case.  This makes the console and fbtest 
look right.... except for the penguins.  Their colors are messed up 
depending on the test order.

John


[-- Attachment #2: patch.16bppfix --]
[-- Type: text/plain, Size: 765 bytes --]

diff -urNX dontdiff linux.old/drivers/video/aty/radeon_base.c linux/drivers/video/aty/radeon_base.c
--- linux.old/drivers/video/aty/radeon_base.c	2003-12-21 17:54:33.000000000 -0500
+++ linux/drivers/video/aty/radeon_base.c	2003-12-23 23:23:03.000000000 -0500
@@ -1197,12 +1197,12 @@
  	if (regno < 16) {
         	switch (rinfo->depth) {
 		case 15:
-			((u16 *) (info->pseudo_palette))[regno] =
+			((u32 *) (info->pseudo_palette))[regno] =
 			    (regno << 10) | (regno << 5) | regno;
 			break;
 		case 16:
-			((u16 *) (info->pseudo_palette))[regno] =
-			    (regno << 11) | (regno << 6) | regno;
+			((u32 *) (info->pseudo_palette))[regno] =
+			    (regno << 11) | (regno << 5) | regno;
 			break;
 		case 24:
 			((u32 *) (info->pseudo_palette))[regno] =