From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
deller@gmx.de, daniel@ffwll.ch, sam@ravnborg.org,
maxime@cerno.tech
Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/11] fbdev: Convert drivers to aperture helpers
Date: Fri, 15 Jul 2022 13:56:37 +0200 [thread overview]
Message-ID: <3b707e5f-ce33-b08d-371b-701b3a84f549@redhat.com> (raw)
In-Reply-To: <558097f5-95bc-fa3c-d08e-1ca0a4d6eec2@suse.de>
Hello Thomas,
On 7/15/22 13:48, Thomas Zimmermann wrote:
[...]
>>> +
>>> + return aperture_remove_conflicting_devices(base, size, primary, "sm750_fb1");
>>
>> Do you know why this can't just use aperture_remove_conflicting_pci_devices() ?
>
> I simply don't want change too much at once, because there was this
> problem with the PCI helper on ast.
>
Makes sense. Feel free to add:
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> At some point we can make a push to really fix this throughout the code
> base. And that would include an update to fb_is_primary_device(), [1]
> which doesn't fill well into the new interfaces.
>
Agreed.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-07-15 11:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 15:39 [PATCH 00/11] fbdev: Maintain device ownership with aperture helpers Thomas Zimmermann
2022-07-07 15:39 ` [PATCH 02/11] fbdev/vga16fb: Create EGA/VGA devices in sysfb code Thomas Zimmermann
2022-07-08 13:09 ` Javier Martinez Canillas
2022-07-11 7:58 ` Thomas Zimmermann
2022-07-11 9:54 ` Javier Martinez Canillas
2022-07-11 10:42 ` Thomas Zimmermann
2022-07-11 10:50 ` Javier Martinez Canillas
2022-07-07 15:39 ` [PATCH 03/11] fbdev/vga16fb: Auto-generate module init/exit code Thomas Zimmermann
2022-07-08 13:16 ` Javier Martinez Canillas
2022-07-11 8:01 ` Thomas Zimmermann
2022-07-11 9:55 ` Javier Martinez Canillas
2022-07-07 15:39 ` [PATCH 04/11] fbdev/core: Remove remove_conflicting_pci_framebuffers() Thomas Zimmermann
2022-07-11 10:51 ` Javier Martinez Canillas
2022-07-07 15:39 ` [PATCH 05/11] fbdev: Convert drivers to aperture helpers Thomas Zimmermann
2022-07-11 11:01 ` Javier Martinez Canillas
2022-07-15 11:48 ` Thomas Zimmermann
2022-07-15 11:56 ` Javier Martinez Canillas [this message]
2022-07-07 15:39 ` [PATCH 06/11] fbdev: Remove conflicting devices on PCI bus Thomas Zimmermann
2022-07-11 11:13 ` Javier Martinez Canillas
2022-07-15 11:52 ` Thomas Zimmermann
2022-07-07 15:39 ` [PATCH 07/11] video/aperture: Disable and unregister sysfb devices via aperture helpers Thomas Zimmermann
2022-07-11 11:16 ` Javier Martinez Canillas
2022-07-07 15:39 ` [PATCH 08/11] video: Provide constants for VGA I/O range Thomas Zimmermann
2022-07-11 11:21 ` Javier Martinez Canillas
2022-07-07 15:39 ` [PATCH 09/11] video/aperture: Remove conflicting VGA devices, if any Thomas Zimmermann
2022-07-11 11:24 ` Javier Martinez Canillas
2022-07-07 15:39 ` [PATCH 10/11] fbdev: Acquire framebuffer apertures for firmware devices Thomas Zimmermann
2022-07-11 11:29 ` Javier Martinez Canillas
2022-07-15 11:58 ` Thomas Zimmermann
2022-07-07 15:39 ` [PATCH 11/11] fbdev: Remove conflict-handling code Thomas Zimmermann
2022-07-11 11:33 ` Javier Martinez Canillas
[not found] ` <20220707153952.32264-2-tzimmermann@suse.de>
2022-07-08 12:49 ` [PATCH 01/11] fbdev: Remove trailing whitespaces Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b707e5f-ce33-b08d-371b-701b3a84f549@redhat.com \
--to=javierm@redhat.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).