From: Helge Deller <deller@gmx.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Chintan Patel <chintanlike@gmail.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
andy@kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v4 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional
Date: Sun, 11 Jan 2026 19:52:46 +0100 [thread overview]
Message-ID: <3bb1ed8b-4aa9-4cdb-b70a-a0dd3f9b2ff9@gmx.de> (raw)
In-Reply-To: <aa922030-b0a1-4503-a3c0-7ce4c36c236e@suse.de>
On 1/7/26 08:33, Thomas Zimmermann wrote:
>
>
> Am 07.01.26 um 05:42 schrieb Chintan Patel:
>> omapfb provides several sysfs interfaces for framebuffer configuration
>> and debugging, but these are not required for the core driver.
>>
>> Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support
>> optional by using dev_of_fbinfo() to obtain the backing device at runtime.
>> When FB_DEVICE is disabled, sysfs operations are skipped while the code
>> still builds and is type-checked.
>>
>> Suggested-by: Helge Deller <deller@gmx.de>
>> Signed-off-by: Chintan Patel <chintanlike@gmail.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
applied to fbdev.
Thanks!
Helge
>> ---
>> drivers/video/fbdev/omap2/omapfb/Kconfig | 3 ++-
>> .../video/fbdev/omap2/omapfb/omapfb-sysfs.c | 18 ++++++++++++++----
>> 2 files changed, 16 insertions(+), 5 deletions(-)
next prev parent reply other threads:[~2026-01-11 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 4:42 [PATCH v4 0/4] fbdev: Make CONFIG_FB_DEVICE optional for drivers Chintan Patel
2026-01-07 4:42 ` [PATCH v4 1/4] fb: Add dev_of_fbinfo() helper for optional sysfs support Chintan Patel
2026-01-07 7:32 ` Thomas Zimmermann
2026-01-11 18:50 ` Helge Deller
2026-01-11 19:51 ` Chintan Patel
2026-01-07 4:42 ` [PATCH v4 2/4] staging: fbtft: Make FB_DEVICE dependency optional Chintan Patel
2026-01-07 7:33 ` Thomas Zimmermann
2026-01-07 15:16 ` Andy Shevchenko
2026-01-07 4:42 ` [PATCH v4 3/4] fbdev: omapfb: " Chintan Patel
2026-01-07 7:33 ` Thomas Zimmermann
2026-01-11 18:52 ` Helge Deller [this message]
2026-01-07 4:42 ` [PATCH v4 4/4] fbdev: sh_mobile_lcdc: " Chintan Patel
2026-01-07 7:33 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb1ed8b-4aa9-4cdb-b70a-a0dd3f9b2ff9@gmx.de \
--to=deller@gmx.de \
--cc=andy@kernel.org \
--cc=chintanlike@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox