From: Helge Deller <deller@gmx.de>
To: "Qianfeng Rong" <rongqianfeng@vivo.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: mb862xxfb: Use int type to store negative error codes
Date: Tue, 30 Sep 2025 20:43:34 +0200 [thread overview]
Message-ID: <3c974071-0ba7-4d24-aa8c-4a1d77c4150b@gmx.de> (raw)
In-Reply-To: <20250830124703.73732-1-rongqianfeng@vivo.com>
On 8/30/25 14:47, Qianfeng Rong wrote:
> Change the 'ret' variable in of_platform_mb862xx_probe() from unsigned long
> to int, as it needs to store either negative error codes or zero.
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied.
Thanks!
Helge
prev parent reply other threads:[~2025-09-30 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 12:47 [PATCH] fbdev: mb862xxfb: Use int type to store negative error codes Qianfeng Rong
2025-09-30 18:43 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c974071-0ba7-4d24-aa8c-4a1d77c4150b@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).