From: Helge Deller <deller@gmx.de>
To: Matthias Goergens <matthias.goergens@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] fbdev: pxafb: fix teardown and early-interrupt lifetimes
Date: Wed, 18 Nov 2026 19:25:28 +0100 [thread overview]
Message-ID: <3cc730f9-2e21-4e1d-9703-4a1adaef54e3@gmx.de> (raw)
In-Reply-To: <20261102080332.1466689-1-matthias.goergens@gmail.com>
On 11/2/26 09:03, Matthias Goergens wrote:
> Three lifetime fixes for problems Sashiko, the AI review bot, pointed
> out while reviewing a pxafb cleanup [1]. Removal leaves the cpufreq
> notifier registered on freed memory and the smart-panel thread running,
> and the interrupt handler can signal completions before probe has
> initialised them.
>
> v2: v1 went out before it was ready, as separate patches without my
> Signed-off-by or Fixes tags, and the completion patch depended on the
> others without saying so; sorry about that. This version adds the tags,
> sends the patches as a series, and says in each commit message what goes
> wrong and how it is reached. The notifier fix is now a patch of its
> own, and the smart-panel patch stops the thread after the controller is
> disabled and no longer changes the thread's freezer loop. Patch 3 is
> unchanged.
>
> I have dropped "fbdev: pxafb: preserve IRQ probe errors". On the
> in-tree PXA platforms the interrupt controller is registered from
> init_IRQ(), before any driver probes, so I could not find a way for
> platform_get_irq() to return -EPROBE_DEFER here, and the patch changed
> nothing users would see.
>
> [1] https://lore.kernel.org/all/20260722081427.413EF1F000E9@smtp.kernel.org/
>
> v1 of patches 1 and 2 ("stop smart-panel thread and notifier"):
> https://lore.kernel.org/all/20261031033248.2491098-1-matthias.goergens@gmail.com/
> v1 of patch 3:
> https://lore.kernel.org/all/20261031003424.1796478-1-matthias.goergens@gmail.com/
> v1 of the dropped patch:
> https://lore.kernel.org/all/20261031033236.2490968-1-matthias.goergens@gmail.com/
>
> Thanks,
> Matthias
>
> Matthias Goergens (3):
> fbdev: pxafb: unregister cpufreq notifier on removal
> fbdev: pxafb: stop the smart-panel thread
> fbdev: pxafb: initialize IRQ completions before requesting IRQ
>
> drivers/video/fbdev/pxafb.c | 46 +++++++++++++++++++++++++++++--------
> 1 file changed, 36 insertions(+), 10 deletions(-)
series applied to fbdev git tree.
Thanks!
Helge
prev parent reply other threads:[~2026-11-18 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 8:03 [PATCH v2 0/3] fbdev: pxafb: fix teardown and early-interrupt lifetimes Matthias Goergens
2026-11-02 8:03 ` [PATCH v2 1/3] fbdev: pxafb: unregister cpufreq notifier on removal Matthias Goergens
2026-11-02 8:03 ` [PATCH v2 2/3] fbdev: pxafb: stop the smart-panel thread Matthias Goergens
2026-11-02 8:03 ` [PATCH v2 3/3] fbdev: pxafb: initialize IRQ completions before requesting IRQ Matthias Goergens
2026-11-18 18:25 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc730f9-2e21-4e1d-9703-4a1adaef54e3@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.goergens@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox