From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BFECCA473 for ; Tue, 21 Jun 2022 12:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350396AbiFUMDs (ORCPT ); Tue, 21 Jun 2022 08:03:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350330AbiFUMDr (ORCPT ); Tue, 21 Jun 2022 08:03:47 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42CB82B240 for ; Tue, 21 Jun 2022 05:03:43 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id fd6so16288041edb.5 for ; Tue, 21 Jun 2022 05:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=20hOXgHS4fSMKzf2+VEVhuMt/xTY7rwW+BkuR688jQI=; b=G0fDoM6iYkilX2J2us0oDAnu2OXLTFoGwQGcIQ61gW+KroUP3F34RD4BJ1IlsFeOKi 8f8+8bvCxI+BjoQhqGDC8Bmih/uM2UMNh0HfP5LHcTP5thFbXw57Wl/JjRk3EIaphPgC /r9iH8r0MZLQ/ZiseG3jh/J+adm1eZ8inUGHNLerNsDK1bRyGyI9t7y5tTAvDDVdeB1B xwLgffZMmNEJhBSsXCtiJaQ53o6MWqYnFwBx1ozBtod/JlyyMz+pR8DZEdtPNbe/8IO5 pZskEbg504lpOOtekPsnMcsUaoBfJ2WNfNfE5rDxevNShYsJWXp++OGVY0izxGKuJIRl k4pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=20hOXgHS4fSMKzf2+VEVhuMt/xTY7rwW+BkuR688jQI=; b=ljmNEztKl2Vq4HOBnCqkeRFlhNTCUKxRb6hB7Zq9mqo5Efwbg41LEu4QCJ8ck9eXtA +NXUxeNyyVZlLAA7y60+vnuQsAKZZsHIbfFN5RuQq7x8CBoZGf3Ukt1wtEnkw8Ma+ae6 f2M2+laqHSJft9sffdiUryrdvB+ibYWVzU/Rbl2vIx9aOtqHh6r3E+tbns3b3f+YGuui ftTJtOzqeTuqK7Usz24tTtNMmvwNiFeMbvSsDj1lctTqpBFjm6yKnPGJS2A37QrvOg1q hnubMbNbOen57z0xI/S7Hyt6Qp+Klpu9+V+rPVBcxx0vf6f7cVHaxxFbnVY4ja6FaFZI z6WQ== X-Gm-Message-State: AJIora9f57GBFyvqTmKMNZnlt3qpWDnOXdhAKe0j+7g/LMdk1uH5MrhV 135iQ/MBLyi+1eN2pSzOLuRgdg== X-Google-Smtp-Source: AGRyM1vuqpi73lfGfP1AhQV/V6GZDUbkiFuWxRqJMB+M0pVkbVaH3yMP1muhb8X6319Kpo4FNFG3DQ== X-Received: by 2002:a05:6402:3689:b0:435:95b0:edf2 with SMTP id ej9-20020a056402368900b0043595b0edf2mr3480378edb.279.1655813021696; Tue, 21 Jun 2022 05:03:41 -0700 (PDT) Received: from [192.168.0.220] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id n12-20020a170906840c00b00706c50870a0sm7470520ejx.194.2022.06.21.05.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 05:03:41 -0700 (PDT) Message-ID: <3e02909d-131a-7899-f02b-fa0afcbef1d9@linaro.org> Date: Tue, 21 Jun 2022 14:03:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 03/15] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator Content-Language: en-US To: szuni chen Cc: ChiaEn Wu , Jonathan Cameron , Lars-Peter Clausen , Matthias Brugger , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-iio , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , dri-devel , Linux LED Subsystem , devicetree , Linux PM , USB , "open list:FRAMEBUFFER LAYER" , ChiYuan Huang References: <20220613111146.25221-1-peterwu.pub@gmail.com> <20220613111146.25221-4-peterwu.pub@gmail.com> <91e9e3af-8208-7535-1864-08744f934593@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On 20/06/2022 05:07, szuni chen wrote: > Dear Krzysztof, > > Thank you for the valuable command. > > Krzysztof Kozlowski 於 2022年6月17日 週五 清晨5:09寫道： >> >> On 13/06/2022 04:11, ChiaEn Wu wrote: >>> From: ChiYuan Huang >>> >>> Add Mediatek mt6370 current sink type LED indicator binding documentation. >>> >>> Signed-off-by: ChiYuan Huang >>> --- >>> .../leds/mediatek,mt6370-indicator.yaml | 48 +++++++++++++++++++ >>> 1 file changed, 48 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >>> new file mode 100644 >>> index 000000000000..42b96c8047a3 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml >>> @@ -0,0 +1,48 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/leds/mediatek,mt6370-indicator.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: LED driver for MT6370 PMIC from MediaTek Integrated. >>> + >>> +maintainers: >>> + - Alice Chen >>> + >>> +description: | >>> + This module is part of the MT6370 MFD device. >>> + Add MT6370 LED driver include 4-channel RGB LED support Register/PWM/Breath Mode >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,mt6370-indicator >>> + >>> + "#address-cells": >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 0 >>> + >>> +patternProperties: >>> + "^(multi-)?led@[0-3]$": >> >> If this is multi-led, then you should reference >> /schemas/leds/leds-pwm-multicolor.yaml >> >> See other examples using it. > > In my opinion, leds-pwm-multicolor.yaml is used for external pwm > signals, and needs to assign an external pwm property. > But our pwm leds use an internal clock to generate the pwm signal. Is > leds-class-multicolor.yaml more appropriate? Yeah, I meant the latter but pasted wrong file. /schemas/leds/leds-class-multicolor.yaml# Best regards, Krzysztof