From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Joe Perches <joe@perches.com>, Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
Kees Cook <keescook@chromium.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs
Date: Tue, 25 Jun 2019 17:06:17 +0000 [thread overview]
Message-ID: <3e40f8c1-9699-2723-4e70-9e91ff256257@embeddedor.com> (raw)
In-Reply-To: <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com>
On 6/25/19 11:52 AM, Joe Perches wrote:
> On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
> []
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>
> Just enable the thing already.
>
> If you stopped trying to do it all yourself, others
What are you talking about?
Anyone can enable it, I'm adding this to every commit:
Warning level 3 was used: -Wimplicit-fallthrough=3
And I'll send a PR with a proper patch for the Makefile
during the next merge window.
If had the power I would have enabled this option since day 1,
so every developer can take care of their own code.
Lately, you are not being of much help, Joe.
--
Gustavo
next prev parent reply other threads:[~2019-06-25 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190625160111epcas3p162f3d789c6219e679d9fd30c6a6b3d51@epcas3p1.samsung.com>
2019-06-25 16:01 ` [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-06-25 16:52 ` Joe Perches
2019-06-25 17:06 ` Gustavo A. R. Silva [this message]
2019-06-25 17:37 ` Joe Perches
2019-06-25 17:31 ` Kees Cook
2019-06-25 17:49 ` Joe Perches
2019-06-25 20:18 ` Kees Cook
2019-07-05 15:16 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e40f8c1-9699-2723-4e70-9e91ff256257@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).