From: Helge Deller <deller@gmx.de>
To: Amit Barzilai <amit.barzilai22@gmail.com>
Cc: thomas.zimmermann@suse.de, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] fbdev: cobalt_lcdfb: Request memory region
Date: Wed, 22 Apr 2026 16:50:12 +0200 [thread overview]
Message-ID: <404ec984-0486-442e-a108-4c5bad700248@gmx.de> (raw)
In-Reply-To: <20260420134424.77494-2-amit.barzilai22@gmail.com>
Hi Amit,
On 4/20/26 15:44, Amit Barzilai wrote:
> Use devm_platform_get_and_ioremap_resource() instead of open-coding
> platform_get_resource() and devm_ioremap() separately. The helper
> requests the memory region before mapping it, which registers the range
> in /proc/iomem and prevents another driver from mapping the same
> registers.
>
> Assisted-by: Claude:claude-sonnet-4-6
You missed your signed-off line, which I added while applying patches #1 and #2:
Signed-off-by: Amit Barzilai <amit.barzilai22@gmail.com>
Amit, please confirm that you wrote patches #2 and #3 and that you
are OK with the added Signed-off-by line, otherwise I need to drop the patches.
Helge
> ---
> drivers/video/fbdev/cobalt_lcdfb.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2026-04-22 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 13:44 [PATCH 0/3] fbdev: Request memory regions in platform drivers Amit Barzilai
2026-04-20 13:44 ` [PATCH 1/3] fbdev: cobalt_lcdfb: Request memory region Amit Barzilai
2026-04-22 14:50 ` Helge Deller [this message]
2026-04-22 15:29 ` Amit Barzilai
2026-04-20 13:44 ` [PATCH 2/3] fbdev: clps711x-fb: Request memory region for MMIO Amit Barzilai
2026-04-20 13:44 ` [PATCH 3/3] fbdev: goldfishfb: Request memory region Amit Barzilai
2026-04-22 14:43 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404ec984-0486-442e-a108-4c5bad700248@gmx.de \
--to=deller@gmx.de \
--cc=amit.barzilai22@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=thomas.zimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox