Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-)

[John Zielinski <grim@undead.cc>]

James Simmons wrote:

>This breaks the way linux works. It is up to the program to restore the 
>console. The same case for vgacon. The X server is the one that restores 
>the graphics hardware back to the VGA text mode. This patch would not ne 
>accepted for a stable release. 
>  
>
No, this would not be for the stable release.  But what I'm saying is 
that it's nice that a program cleans up after itself but we shouldn't 
rely on it.  Take resources like memory, file handles, sockets, etc.  
Most program release those resources when the shut down normally but 
what if they seg fault or exit unexpectedly?  The kernel cleans up after 
the process regardless.

So if a fb program restores the mode properly then we should do nothing 
but if it doesn't either because of a bad programming or an unexpected 
termination then we should reset the mode to what the user has selected 
for their console.

John




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click