linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* radeonfb_pci_register video memory clear?
@ 2004-06-19  2:20 John Zielinski
  2004-06-19 19:27 ` Kronos
  2004-06-23 15:52 ` Benjamin Herrenschmidt
  0 siblings, 2 replies; 6+ messages in thread
From: John Zielinski @ 2004-06-19  2:20 UTC (permalink / raw)
  To: Linux Frame Buffer Device Development

I'm just wondering why the clearing of video memory was added to 
radeonfb_pci_register?  The memory still belongs to vgacon at this 
point.  There are a few other problems with this:  there is a noticable 
delay while the screen is totaly blank,  vgacon can't save the text 
screen to the shadow buffer, and all further output until the takeover 
is invisible (vga font is wiped) so an oops here wouldn't be readable.

John




-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: radeonfb_pci_register video memory clear?
  2004-06-19  2:20 radeonfb_pci_register video memory clear? John Zielinski
@ 2004-06-19 19:27 ` Kronos
  2004-06-19 19:46   ` John Zielinski
  2004-06-23 15:52 ` Benjamin Herrenschmidt
  1 sibling, 1 reply; 6+ messages in thread
From: Kronos @ 2004-06-19 19:27 UTC (permalink / raw)
  To: John Zielinski; +Cc: Linux Frame Buffer Device Development

Il Fri, Jun 18, 2004 at 10:20:17PM -0400, John Zielinski ha scritto: 
> *This message was transferred with a trial version of CommuniGate(tm) Pro*
> I'm just wondering why the clearing of video memory was added to 
> radeonfb_pci_register? 

AFAIK without that radeonfb will display the content of the memory as
random garbage.

Luca
-- 
Home: http://kronoz.cjb.net
Software is like sex; it's better when it's free.
Linus Torvalds


-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: radeonfb_pci_register video memory clear?
  2004-06-19 19:27 ` Kronos
@ 2004-06-19 19:46   ` John Zielinski
  2004-06-23 15:56     ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 6+ messages in thread
From: John Zielinski @ 2004-06-19 19:46 UTC (permalink / raw)
  To: Kronos; +Cc: Linux Frame Buffer Device Development

Kronos wrote:

>AFAIK without that radeonfb will display the content of the memory as
>random garbage.
>  
>
I does fix it but the side effects I listed make it a bad idea, 
especially the fact that the radeonfb driver doesn't own the memory 
yet.  Tony has posted a proper fix for the problem so whoever put this 
in, please remove it.

John




-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: radeonfb_pci_register video memory clear?
  2004-06-19  2:20 radeonfb_pci_register video memory clear? John Zielinski
  2004-06-19 19:27 ` Kronos
@ 2004-06-23 15:52 ` Benjamin Herrenschmidt
  1 sibling, 0 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2004-06-23 15:52 UTC (permalink / raw)
  To: John Zielinski; +Cc: Linux Frame Buffer Device Development

On Fri, 2004-06-18 at 21:20, John Zielinski wrote:
> I'm just wondering why the clearing of video memory was added to 
> radeonfb_pci_register?  The memory still belongs to vgacon at this 
> point.  There are a few other problems with this:  there is a noticable 
> delay while the screen is totaly blank,  vgacon can't save the text 
> screen to the shadow buffer, and all further output until the takeover 
> is invisible (vga font is wiped) so an oops here wouldn't be readable.

I added that to fix reports of users complaining they had garbage displayed
on boot. I didn't think about the interaction with vgacon (see, I have
absolutely no legacy hardware doing crappy VGA mode ;)

Maybe that should be reversed ....

Ben.




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: radeonfb_pci_register video memory clear?
  2004-06-19 19:46   ` John Zielinski
@ 2004-06-23 15:56     ` Benjamin Herrenschmidt
  2004-06-23 16:07       ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2004-06-23 15:56 UTC (permalink / raw)
  To: John Zielinski; +Cc: Kronos, Linux Frame Buffer Device Development

On Sat, 2004-06-19 at 14:46, John Zielinski wrote:
> Kronos wrote:
> 
> >AFAIK without that radeonfb will display the content of the memory as
> >random garbage.
> >  
> >
> I does fix it but the side effects I listed make it a bad idea, 
> especially the fact that the radeonfb driver doesn't own the memory 
> yet.  Tony has posted a proper fix for the problem so whoever put this 
> in, please remove it.

Provided Tony fix gets upstream instead of beeing lost for 6 more
monthes in the fbdev tree ...

Ben.




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: radeonfb_pci_register video memory clear?
  2004-06-23 15:56     ` Benjamin Herrenschmidt
@ 2004-06-23 16:07       ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2004-06-23 16:07 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: John Zielinski, Kronos, Linux Frame Buffer Device Development

On Wed, 23 Jun 2004, Benjamin Herrenschmidt wrote:
> On Sat, 2004-06-19 at 14:46, John Zielinski wrote:
> > >AFAIK without that radeonfb will display the content of the memory as
> > >random garbage.
> > >
> > I does fix it but the side effects I listed make it a bad idea,
> > especially the fact that the radeonfb driver doesn't own the memory
> > yet.  Tony has posted a proper fix for the problem so whoever put this
> > in, please remove it.
>
> Provided Tony fix gets upstream instead of beeing lost for 6 more
> monthes in the fbdev tree ...

Nah, Tony is doing his best to get stuff merged with Andrew...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-06-23 16:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-19  2:20 radeonfb_pci_register video memory clear? John Zielinski
2004-06-19 19:27 ` Kronos
2004-06-19 19:46   ` John Zielinski
2004-06-23 15:56     ` Benjamin Herrenschmidt
2004-06-23 16:07       ` Geert Uytterhoeven
2004-06-23 15:52 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).