Re: Sane behavior of fbset

[John Zielinski <grim@undead.cc>]

jsimmons@pentafluge.infradead.org wrote:

>Good catch. We need a flag to determine which layer it came from. Tony 
>posted a patch dealing with that.
>  
>
I took a look and I'm going to merge that into my kernel and trace 
trough the ioctl call paths again.  The VT_RESIZE path looks good with 
his patch but I think that the FBIOPUT_VSCREENINFO may loop through a 
few functions a second time.  I'll know for sure when I trace things out 
later.

But my thinking was that vc_resize (or part of it split of into a 
seperate function) should be the final terminus of the code path.  That 
way you wouldn't need flags or anything else to break out of the 
circular code path we have now.  The code would be easier to follow and 
be less prone to mistakes.

I'll see if I can whip up a patch that works with our current single var 
to show you what I mean.

John




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com