From: Helge Deller <deller@gmx.de>
To: ye.xingchen@zte.com.cn
Cc: javierm@redhat.com, tzimmermann@suse.de, geert+renesas@glider.be,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v3] fbdev: use sysfs_emit() to instead of scnprintf()
Date: Sat, 10 Dec 2022 17:15:22 +0100 [thread overview]
Message-ID: <40d7b576-9e4d-8d05-9273-48874d53591f@gmx.de> (raw)
In-Reply-To: <202212051631391777945@zte.com.cn>
On 12/5/22 09:31, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
I've applied this patch, but split it up into two (one for each driver).
Please, send seperate patches per driver next time (and add proper changelog
if you do a v2/v3 version).
Thanks!
Helge
> ---
> v2 -> v3
> Fix the mistakes in v2.
> drivers/video/fbdev/sh_mobile_lcdcfb.c | 8 ++++----
> drivers/video/fbdev/uvesafb.c | 10 +++++-----
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
> index 6d00893d41f4..ad9323ed8e2e 100644
> --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
> +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
> @@ -1188,7 +1188,7 @@ overlay_alpha_show(struct device *dev, struct device_attribute *attr, char *buf)
> struct fb_info *info = dev_get_drvdata(dev);
> struct sh_mobile_lcdc_overlay *ovl = info->par;
>
> - return scnprintf(buf, PAGE_SIZE, "%u\n", ovl->alpha);
> + return sysfs_emit(buf, "%u\n", ovl->alpha);
> }
>
> static ssize_t
> @@ -1226,7 +1226,7 @@ overlay_mode_show(struct device *dev, struct device_attribute *attr, char *buf)
> struct fb_info *info = dev_get_drvdata(dev);
> struct sh_mobile_lcdc_overlay *ovl = info->par;
>
> - return scnprintf(buf, PAGE_SIZE, "%u\n", ovl->mode);
> + return sysfs_emit(buf, "%u\n", ovl->mode);
> }
>
> static ssize_t
> @@ -1265,7 +1265,7 @@ overlay_position_show(struct device *dev, struct device_attribute *attr,
> struct fb_info *info = dev_get_drvdata(dev);
> struct sh_mobile_lcdc_overlay *ovl = info->par;
>
> - return scnprintf(buf, PAGE_SIZE, "%d,%d\n", ovl->pos_x, ovl->pos_y);
> + return sysfs_emit(buf, "%d,%d\n", ovl->pos_x, ovl->pos_y);
> }
>
> static ssize_t
> @@ -1306,7 +1306,7 @@ overlay_rop3_show(struct device *dev, struct device_attribute *attr, char *buf)
> struct fb_info *info = dev_get_drvdata(dev);
> struct sh_mobile_lcdc_overlay *ovl = info->par;
>
> - return scnprintf(buf, PAGE_SIZE, "%u\n", ovl->rop3);
> + return sysfs_emit(buf, "%u\n", ovl->rop3);
> }
>
> static ssize_t
> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
> index 00d789b6c0fa..ba8028a0cc7a 100644
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -1580,7 +1580,7 @@ static ssize_t uvesafb_show_vendor(struct device *dev,
> struct uvesafb_par *par = info->par;
>
> if (par->vbe_ib.oem_vendor_name_ptr)
> - return scnprintf(buf, PAGE_SIZE, "%s\n", (char *)
> + return sysfs_emit(buf, "%s\n", (char *)
> (&par->vbe_ib) + par->vbe_ib.oem_vendor_name_ptr);
> else
> return 0;
> @@ -1595,7 +1595,7 @@ static ssize_t uvesafb_show_product_name(struct device *dev,
> struct uvesafb_par *par = info->par;
>
> if (par->vbe_ib.oem_product_name_ptr)
> - return scnprintf(buf, PAGE_SIZE, "%s\n", (char *)
> + return sysfs_emit(buf, "%s\n", (char *)
> (&par->vbe_ib) + par->vbe_ib.oem_product_name_ptr);
> else
> return 0;
> @@ -1610,7 +1610,7 @@ static ssize_t uvesafb_show_product_rev(struct device *dev,
> struct uvesafb_par *par = info->par;
>
> if (par->vbe_ib.oem_product_rev_ptr)
> - return scnprintf(buf, PAGE_SIZE, "%s\n", (char *)
> + return sysfs_emit(buf, "%s\n", (char *)
> (&par->vbe_ib) + par->vbe_ib.oem_product_rev_ptr);
> else
> return 0;
> @@ -1625,7 +1625,7 @@ static ssize_t uvesafb_show_oem_string(struct device *dev,
> struct uvesafb_par *par = info->par;
>
> if (par->vbe_ib.oem_string_ptr)
> - return scnprintf(buf, PAGE_SIZE, "%s\n",
> + return sysfs_emit(buf, "%s\n",
> (char *)(&par->vbe_ib) + par->vbe_ib.oem_string_ptr);
> else
> return 0;
> @@ -1639,7 +1639,7 @@ static ssize_t uvesafb_show_nocrtc(struct device *dev,
> struct fb_info *info = dev_get_drvdata(dev);
> struct uvesafb_par *par = info->par;
>
> - return scnprintf(buf, PAGE_SIZE, "%d\n", par->nocrtc);
> + return sysfs_emit(buf, "%d\n", par->nocrtc);
> }
>
> static ssize_t uvesafb_store_nocrtc(struct device *dev,
prev parent reply other threads:[~2022-12-10 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 8:31 [PATCH linux-next v3] fbdev: use sysfs_emit() to instead of scnprintf() ye.xingchen
2022-12-05 8:47 ` Geert Uytterhoeven
2022-12-10 16:15 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40d7b576-9e4d-8d05-9273-48874d53591f@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox