linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zack <plinius@comcast.net>
To: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: fbdraw 0.1 available
Date: Sun, 12 Sep 2004 17:31:20 -0700	[thread overview]
Message-ID: <4144EA58.4080900@comcast.net> (raw)
In-Reply-To: <200409120340.04133.adaplas@hotpop.com>

Antonino A. Daplas wrote:

> 1. First, you need to follow Documentation/CodingStyle.

OK, I've made some strides in that direction.

> 2. Do not directly access framebuffer memory, use: 
> 3. Do not use copy_{to|from}_user when the destination/source is the
> framebuffer.
> 4. Do not memset the framebuffer.  You can probably create an equivalent
> function using fb_read/write.  (Once, we have fb_memset and fb_memcpy, but
> they're gone in 2.6).

Fixed.

Incidentally I am wondering, with cross-platform compatibility
in mind I have been coding assuming that fb_{read|write}[wl] must be
short/long aligned. Is that assumption correct?

I've also added my copyarea routine. At first I tried to make use
of cfb_copyarea but it proved very buggy in 24bpp.

New code is at http://home.comcast.net/~plinius.
Cheers,
Zack


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php

  reply	other threads:[~2004-09-13  0:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-11  2:43 fbdraw 0.1 available Zack
2004-09-11 10:53 ` Geert Uytterhoeven
2004-09-11 18:09   ` Zack
2004-09-11 19:40 ` Antonino A. Daplas
2004-09-13  0:31   ` Zack [this message]
2004-09-13 11:18     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4144EA58.4080900@comcast.net \
    --to=plinius@comcast.net \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).