Re: Default timings in vga16fb driver

[Martin Wilck <martin.wilck@fujitsu-siemens.com>]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Antonino A. Daplas wrote:

> I don't think you overlooked anything. The default modeline of vga16fb
> should be corrected.

OK, so here's the patch (using the timings from /etc/fb.modes). Should I 
send it to linux-kernel, too?

Martin

-- 
Martin Wilck                Phone: +49 5251 8 15113
Fujitsu Siemens Computers   Fax:   +49 5251 8 20409
Heinz-Nixdorf-Ring 1        mailto:Martin.Wilck@Fujitsu-Siemens.com
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy


[-- Attachment #2: vga16.diff --]
[-- Type: text/x-patch, Size: 1008 bytes --]

Patch:	Fix default timings in vga16fb.c

Author: Martin Wilck <Martin.Wilck@Fujitsu-Siemens.com>
Signed-off-by: Martin Wilck <Martin.Wilck@Fujitsu-Siemens.com>

This patch adapts the timings of the default mode in vga16fb.c
to the 640x480-60 timings in /etc/fb.modes. 

In particular, the total screen height is fixed to be 525 pixels 
rather than 529. The height of 529 was causing trouble on some LCD displays.

(Note: To make the mode 100% identical to the one in /etc/fb.modes,
the pixclock must be set to 39722, too; I didn't want to do that here).

--- linux-2.6.5-7.111/drivers/video/vga16fb.c.orig	2004-11-25 15:38:11.000000000 +0100
+++ linux-2.6.5-7.111/drivers/video/vga16fb.c	2004-11-25 15:45:54.000000000 +0100
@@ -91,8 +91,8 @@ static struct fb_var_screeninfo vga16fb_
 	.pixclock	= 39721,
 	.left_margin	= 48,
 	.right_margin	= 16,
-	.upper_margin	= 39,
-	.lower_margin	= 8,
+	.upper_margin	= 33,
+	.lower_margin	= 10,
 	.hsync_len 	= 96,
 	.vsync_len	= 2,
 	.vmode		= FB_VMODE_NONINTERLACED,