From: Sylvain Meyer <sylvain.meyer@worldonline.fr>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: "Randy.Dunlap" <rddunlap@osdl.org>
Subject: Re: intelfb stack usage
Date: Sun, 19 Dec 2004 17:16:47 +0100 [thread overview]
Message-ID: <41C5A96F.1090705@worldonline.fr> (raw)
In-Reply-To: 200412180814.30855.adaplas@hotpop.com
If you can do it, thanks. I won't have any time until next year.
Sylvain
Antonino A. Daplas a écrit:
>On Saturday 18 December 2004 03:17, Randy.Dunlap wrote:
>
>
>>In 2.6.10-rc3-bk6, intelfb_set_par() has the distinction of being
>>the largest stack user as determined by 'make checkstack':
>>
>>objdump -d vmlinux $(find . -name '*.ko') | \
>>perl /mnt/src/linux-2610-rc3-bk6/scripts/checkstack.pl i386
>>0x00001317 intelfb_set_par: 2404
>>
>>because it has this large struct on the stack:
>> struct intelfb_hwstate hw;
>>(almost 2400 bytes)
>>
>>Any suggestions for how to alleviate this large stack usage?
>>
>> From a quick look, this is called from fb_ioctl() to fb_set_var()
>>to fb_set_par().
>>fb_ioctl() does acquire_console_sem(), so using kmalloc()
>>here would need to use GFP_ATOMIC...
>>I can do that if it's desired & acceptable.
>>
>>
>
>Using kmalloc() should be acceptable. I'll CC the author.
>
>Tony
>
>
>
>
>-------------------------------------------------------
>SF email is sponsored by - The IT Product Guide
>Read honest & candid reviews on hundreds of IT Products from real users.
>Discover which products truly live up to the hype. Start reading now.
>http://productguide.itmanagersjournal.com/
>_______________________________________________
>Linux-fbdev-devel mailing list
>Linux-fbdev-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
>
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
prev parent reply other threads:[~2004-12-19 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-17 19:17 intelfb stack usage Randy.Dunlap
2004-12-18 0:14 ` Antonino A. Daplas
2004-12-19 16:16 ` Sylvain Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C5A96F.1090705@worldonline.fr \
--to=sylvain.meyer@worldonline.fr \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).