Fbcon issue

Fbcon issue

[Imago]

Hi
while doing some bug hunting for another project I discovered an issue
which is imho a bug in fbcon.
The problem is that each virtual console has its own color palette but
the framebuffer only has one color map.
So, for example, if im running fbcon on vt1 and set there a non-default
colormap and then allocate a new vt, for which the standard
color palette is set, also the framebuffer colormap is set back to the
default.Which will lead to color corruption on the actual vt.
A fix could be to allow setting of color palette only for the foreground
console,
ie change following in fbcon.c: fbcon_set_palette() at line 2400:

if (fbcon_is_inactive(vc, info))
                return -EINVAL;

to

if ( fbcon_is_inactive(vc, info) ||  (vc->vc_num != fg_console) )
                return -EINVAL;

Cu
Peter




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/